Rewrite enum in MACRO_STYLE

Rewrite enum in MACRO_STYLE

Files with related issue:
snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc

Related files are edited to match the style.

BUG=619215
Committed: https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e
Cr-Commit-Position: refs/heads/master@{#399526}

[Vivian, 2016-06-11 01:42:24]

weiran@google.com changed reviewers:
+ fgorski@chromium.org

[Vivian, 2016-06-11 01:42:24]

ptal

[chili, 2016-06-11 03:11:45]

Just FYI, https://codereview.chromium.org/2038963002/ may introduce stuff to
update too

Probably your CL will land first so no-op for you, but just in case :)

[fgorski, 2016-06-11 16:25:06]

Thanks for working on this. Looks really good. Only a couple of comments to
address. Please run the tests after update.

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_queue.h (right):

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_queue.h:40: // exist.
nit: align the line to the comment above.

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/sn...
File components/offline_pages/snapshot_controller.h (right):

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/sn...
components/offline_pages/snapshot_controller.h:32: READY,
Put documentation after the definition of the enum, like in other files please.
Make sure to align with the deepest comment (2 spaces after SNAPSHOT_PENDING,)
and use Sentence case, e.g.
Snapshot is in ... another.

[fgorski, 2016-06-11 16:25:06]

Thanks for working on this. Looks really good. Only a couple of comments to
address. Please run the tests after update.

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_queue.h (right):

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_queue.h:40: // exist.
nit: align the line to the comment above.

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/sn...
File components/offline_pages/snapshot_controller.h (right):

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/sn...
components/offline_pages/snapshot_controller.h:32: READY,
Put documentation after the definition of the enum, like in other files please.
Make sure to align with the deepest comment (2 spaces after SNAPSHOT_PENDING,)
and use Sentence case, e.g.
Snapshot is in ... another.

[Vivian, 2016-06-13 17:07:05]

Thanks for the comments, just uploaded a new path.

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/ba...
File components/offline_pages/background/request_queue.h (right):

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/ba...
components/offline_pages/background/request_queue.h:40: // exist.
On 2016/06/11 16:25:06, fgorski wrote:
> nit: align the line to the comment above.

Done.

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/sn...
File components/offline_pages/snapshot_controller.h (right):

https://codereview.chromium.org/2063533002/diff/1/components/offline_pages/sn...
components/offline_pages/snapshot_controller.h:32: READY,
On 2016/06/11 16:25:06, fgorski wrote:
> Put documentation after the definition of the enum, like in other files
please.
> Make sure to align with the deepest comment (2 spaces after SNAPSHOT_PENDING,)
> and use Sentence case, e.g.
> Snapshot is in ... another.

Done.

[Vivian, 2016-06-13 17:07:06]

Thanks for the comments, just uploaded a new path.

[fgorski, 2016-06-13 17:10:07]

On 2016/06/13 17:07:06, Vivian wrote:
> Thanks for the comments, just uploaded a new path.

lgtm, please start the bots.

[Vivian, 2016-06-13 17:11:33]

The CQ bit was checked by weiran@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 17:11:57]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063533002/20001

[commit-bot: I haz the power, 2016-06-13 17:24:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 17:24:25]

Dry run: Try jobs failed on following builders:
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Vivian, 2016-06-13 18:23:02]

The CQ bit was checked by weiran@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 18:23:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063533002/40001

[commit-bot: I haz the power, 2016-06-13 19:54:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 19:54:34]

Dry run: This issue passed the CQ dry run.

[Vivian, 2016-06-13 20:24:13]

The CQ bit was checked by weiran@google.com

[Vivian, 2016-06-13 20:24:16]

The patchset sent to the CQ was uploaded after l-g-t-m from fgorski@chromium.org
Link to the patchset: https://codereview.chromium.org/2063533002/#ps40001
(title: "Change enum name to match ios convention")

[commit-bot: I haz the power, 2016-06-13 20:25:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2063533002/40001

[commit-bot: I haz the power, 2016-06-13 20:34:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-13 20:34:09]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-13 20:35:45]

Description was changed from

==========
Rewrite enum in MACRO_STYLE

Files with related issue:
snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc

Related files are edited to match the style.

BUG=619215
==========

to

==========
Rewrite enum in MACRO_STYLE

Files with related issue:
snapshot_controller.h
request_queue.h
save_page_request.h
request_queue_store.h
request_queue_in_memory_store_unittest.cc

Related files are edited to match the style.

BUG=619215

Committed: https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e
Cr-Commit-Position: refs/heads/master@{#399526}
==========

[commit-bot: I haz the power, 2016-06-13 20:35:47]

Patchset 3 (id:??) landed as
https://crrev.com/92c8b28dafc2d4748d5f7d4755320271e5319e1e
Cr-Commit-Position: refs/heads/master@{#399526}