Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Side by Side Diff: components/offline_pages/background/request_queue_unittest.cc

Issue 2063533002: Rewrite enum in MACRO_STYLE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change enum name to match ios convention Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/offline_pages/background/request_queue.h" 5 #include "components/offline_pages/background/request_queue.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/test/test_simple_task_runner.h" 10 #include "base/test/test_simple_task_runner.h"
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 73
74 GetRequestsResult last_get_requests_result_; 74 GetRequestsResult last_get_requests_result_;
75 std::vector<SavePageRequest> last_requests_; 75 std::vector<SavePageRequest> last_requests_;
76 76
77 std::unique_ptr<RequestQueue> queue_; 77 std::unique_ptr<RequestQueue> queue_;
78 scoped_refptr<base::TestSimpleTaskRunner> task_runner_; 78 scoped_refptr<base::TestSimpleTaskRunner> task_runner_;
79 base::ThreadTaskRunnerHandle task_runner_handle_; 79 base::ThreadTaskRunnerHandle task_runner_handle_;
80 }; 80 };
81 81
82 RequestQueueTest::RequestQueueTest() 82 RequestQueueTest::RequestQueueTest()
83 : last_add_result_(AddRequestResult::kStoreFailure), 83 : last_add_result_(AddRequestResult::STORE_FAILURE),
84 last_remove_result_(UpdateRequestResult::kStoreFailure), 84 last_remove_result_(UpdateRequestResult::STORE_FAILURE),
85 last_get_requests_result_(GetRequestsResult::kStoreFailure), 85 last_get_requests_result_(GetRequestsResult::STORE_FAILURE),
86 task_runner_(new base::TestSimpleTaskRunner), 86 task_runner_(new base::TestSimpleTaskRunner),
87 task_runner_handle_(task_runner_) {} 87 task_runner_handle_(task_runner_) {}
88 88
89 RequestQueueTest::~RequestQueueTest() {} 89 RequestQueueTest::~RequestQueueTest() {}
90 90
91 void RequestQueueTest::SetUp() { 91 void RequestQueueTest::SetUp() {
92 std::unique_ptr<RequestQueueInMemoryStore> store( 92 std::unique_ptr<RequestQueueInMemoryStore> store(
93 new RequestQueueInMemoryStore()); 93 new RequestQueueInMemoryStore());
94 queue_.reset(new RequestQueue(std::move(store))); 94 queue_.reset(new RequestQueue(std::move(store)));
95 } 95 }
(...skipping 16 matching lines...) Expand all
112 } 112 }
113 113
114 void RequestQueueTest::RemoveRequestDone(UpdateRequestResult result) { 114 void RequestQueueTest::RemoveRequestDone(UpdateRequestResult result) {
115 last_remove_result_ = result; 115 last_remove_result_ = result;
116 } 116 }
117 117
118 TEST_F(RequestQueueTest, GetRequestsEmpty) { 118 TEST_F(RequestQueueTest, GetRequestsEmpty) {
119 queue()->GetRequests( 119 queue()->GetRequests(
120 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 120 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
121 PumpLoop(); 121 PumpLoop();
122 ASSERT_EQ(GetRequestsResult::kSuccess, last_get_requests_result()); 122 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
123 ASSERT_EQ(0ul, last_requests().size()); 123 ASSERT_EQ(0ul, last_requests().size());
124 } 124 }
125 125
126 TEST_F(RequestQueueTest, AddRequest) { 126 TEST_F(RequestQueueTest, AddRequest) {
127 base::Time creation_time = base::Time::Now(); 127 base::Time creation_time = base::Time::Now();
128 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time); 128 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
129 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone, 129 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
130 base::Unretained(this))); 130 base::Unretained(this)));
131 PumpLoop(); 131 PumpLoop();
132 ASSERT_EQ(AddRequestResult::kSuccess, last_add_result()); 132 ASSERT_EQ(AddRequestResult::SUCCESS, last_add_result());
133 ASSERT_TRUE(last_added_request()); 133 ASSERT_TRUE(last_added_request());
134 ASSERT_EQ(kRequestId, last_added_request()->request_id()); 134 ASSERT_EQ(kRequestId, last_added_request()->request_id());
135 135
136 queue()->GetRequests( 136 queue()->GetRequests(
137 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 137 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
138 PumpLoop(); 138 PumpLoop();
139 ASSERT_EQ(GetRequestsResult::kSuccess, last_get_requests_result()); 139 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
140 ASSERT_EQ(1ul, last_requests().size()); 140 ASSERT_EQ(1ul, last_requests().size());
141 } 141 }
142 142
143 TEST_F(RequestQueueTest, RemoveRequest) { 143 TEST_F(RequestQueueTest, RemoveRequest) {
144 base::Time creation_time = base::Time::Now(); 144 base::Time creation_time = base::Time::Now();
145 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time); 145 SavePageRequest request(kRequestId, kUrl, kClientId, creation_time);
146 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone, 146 queue()->AddRequest(request, base::Bind(&RequestQueueTest::AddRequestDone,
147 base::Unretained(this))); 147 base::Unretained(this)));
148 PumpLoop(); 148 PumpLoop();
149 ASSERT_EQ(kRequestId, last_added_request()->request_id()); 149 ASSERT_EQ(kRequestId, last_added_request()->request_id());
150 150
151 queue()->RemoveRequest( 151 queue()->RemoveRequest(
152 kRequestId, 152 kRequestId,
153 base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this))); 153 base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
154 PumpLoop(); 154 PumpLoop();
155 ASSERT_EQ(UpdateRequestResult::kSuccess, last_remove_result()); 155 ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
156 156
157 queue()->GetRequests( 157 queue()->GetRequests(
158 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 158 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
159 PumpLoop(); 159 PumpLoop();
160 ASSERT_EQ(GetRequestsResult::kSuccess, last_get_requests_result()); 160 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
161 ASSERT_EQ(0ul, last_requests().size()); 161 ASSERT_EQ(0ul, last_requests().size());
162 } 162 }
163 163
164 // A longer test populating the request queue with more than one item, properly 164 // A longer test populating the request queue with more than one item, properly
165 // listing multiple items and removing the right item. 165 // listing multiple items and removing the right item.
166 TEST_F(RequestQueueTest, MultipleRequestsAddGetRemove) { 166 TEST_F(RequestQueueTest, MultipleRequestsAddGetRemove) {
167 base::Time creation_time = base::Time::Now(); 167 base::Time creation_time = base::Time::Now();
168 SavePageRequest request1(kRequestId, kUrl, kClientId, creation_time); 168 SavePageRequest request1(kRequestId, kUrl, kClientId, creation_time);
169 queue()->AddRequest(request1, base::Bind(&RequestQueueTest::AddRequestDone, 169 queue()->AddRequest(request1, base::Bind(&RequestQueueTest::AddRequestDone,
170 base::Unretained(this))); 170 base::Unretained(this)));
171 PumpLoop(); 171 PumpLoop();
172 ASSERT_EQ(request1.request_id(), last_added_request()->request_id()); 172 ASSERT_EQ(request1.request_id(), last_added_request()->request_id());
173 SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time); 173 SavePageRequest request2(kRequestId2, kUrl2, kClientId2, creation_time);
174 queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone, 174 queue()->AddRequest(request2, base::Bind(&RequestQueueTest::AddRequestDone,
175 base::Unretained(this))); 175 base::Unretained(this)));
176 PumpLoop(); 176 PumpLoop();
177 ASSERT_EQ(request2.request_id(), last_added_request()->request_id()); 177 ASSERT_EQ(request2.request_id(), last_added_request()->request_id());
178 178
179 queue()->GetRequests( 179 queue()->GetRequests(
180 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 180 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
181 PumpLoop(); 181 PumpLoop();
182 ASSERT_EQ(GetRequestsResult::kSuccess, last_get_requests_result()); 182 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
183 ASSERT_EQ(2ul, last_requests().size()); 183 ASSERT_EQ(2ul, last_requests().size());
184 184
185 queue()->RemoveRequest( 185 queue()->RemoveRequest(
186 request1.request_id(), 186 request1.request_id(),
187 base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this))); 187 base::Bind(&RequestQueueTest::RemoveRequestDone, base::Unretained(this)));
188 PumpLoop(); 188 PumpLoop();
189 ASSERT_EQ(UpdateRequestResult::kSuccess, last_remove_result()); 189 ASSERT_EQ(UpdateRequestResult::SUCCESS, last_remove_result());
190 190
191 queue()->GetRequests( 191 queue()->GetRequests(
192 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this))); 192 base::Bind(&RequestQueueTest::GetRequestsDone, base::Unretained(this)));
193 PumpLoop(); 193 PumpLoop();
194 ASSERT_EQ(GetRequestsResult::kSuccess, last_get_requests_result()); 194 ASSERT_EQ(GetRequestsResult::SUCCESS, last_get_requests_result());
195 ASSERT_EQ(1ul, last_requests().size()); 195 ASSERT_EQ(1ul, last_requests().size());
196 ASSERT_EQ(request2.request_id(), last_requests()[0].request_id()); 196 ASSERT_EQ(request2.request_id(), last_requests()[0].request_id());
197 } 197 }
198 198
199 } // namespace offline_pages 199 } // namespace offline_pages
OLDNEW
« no previous file with comments | « components/offline_pages/background/request_queue_store.h ('k') | components/offline_pages/background/save_page_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698