components/offline_pages/background/request_queue_store.h - Issue 2063533002: Rewrite enum in MACRO_STYLE

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/offline_pages/background/request_queue_store.h

Issue 2063533002: Rewrite enum in MACRO_STYLE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Change enum name to match ios convention Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/offline_pages/background/request_queue_store.h

diff --git a/components/offline_pages/background/request_queue_store.h b/components/offline_pages/background/request_queue_store.h

index 076430a139fe3fb716c06c35ec59527bf37fd72e..0fd34a32aed34abaa1a57108d63751e5797f384a 100644

--- a/components/offline_pages/background/request_queue_store.h

+++ b/components/offline_pages/background/request_queue_store.h

@@ -18,9 +18,9 @@ class SavePageRequest;

class RequestQueueStore {

public:

enum class UpdateStatus {

- kAdded, // Request was added successfully.

- kUpdated, // Request was updated successfully.

- kFailed, // Add or update attempt failed.

+ ADDED, // Request was added successfully.

+ UPDATED, // Request was updated successfully.

+ FAILED, // Add or update attempt failed.

};

typedef base::Callback<void(