Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(504)

Unified Diff: components/offline_pages/background/request_queue.cc

Issue 2063533002: Rewrite enum in MACRO_STYLE (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Change enum name to match ios convention Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/background/request_queue.cc
diff --git a/components/offline_pages/background/request_queue.cc b/components/offline_pages/background/request_queue.cc
index ae9b0a4e5a1112fd99180c765546a863c7b22d72..7626601a6a8cd80849debdcf021f4cf5db1c654e 100644
--- a/components/offline_pages/background/request_queue.cc
+++ b/components/offline_pages/background/request_queue.cc
@@ -18,8 +18,8 @@ void GetRequestsDone(const RequestQueue::GetRequestsCallback& callback,
bool success,
const std::vector<SavePageRequest>& requests) {
RequestQueue::GetRequestsResult result =
- success ? RequestQueue::GetRequestsResult::kSuccess
- : RequestQueue::GetRequestsResult::kStoreFailure;
+ success ? RequestQueue::GetRequestsResult::SUCCESS
+ : RequestQueue::GetRequestsResult::STORE_FAILURE;
// TODO(fgorski): Filter out expired requests based on policy.
// This may trigger the purging if necessary.
// Also this may be turned into a method on the request queue or add a policy
@@ -32,9 +32,9 @@ void AddRequestDone(const RequestQueue::AddRequestCallback& callback,
const SavePageRequest& request,
RequestQueueStore::UpdateStatus status) {
RequestQueue::AddRequestResult result =
- (status == RequestQueueStore::UpdateStatus::kAdded)
- ? RequestQueue::AddRequestResult::kSuccess
- : RequestQueue::AddRequestResult::kStoreFailure;
+ (status == RequestQueueStore::UpdateStatus::ADDED)
+ ? RequestQueue::AddRequestResult::SUCCESS
+ : RequestQueue::AddRequestResult::STORE_FAILURE;
callback.Run(result, request);
}
@@ -44,8 +44,8 @@ void RemoveRequestDone(const RequestQueue::UpdateRequestCallback& callback,
int deleted_requests_count) {
DCHECK_EQ(1, deleted_requests_count);
RequestQueue::UpdateRequestResult result =
- success ? RequestQueue::UpdateRequestResult::kSuccess
- : RequestQueue::UpdateRequestResult::kStoreFailure;
+ success ? RequestQueue::UpdateRequestResult::SUCCESS
+ : RequestQueue::UpdateRequestResult::STORE_FAILURE;
callback.Run(result);
}
} // namespace

Powered by Google App Engine
This is Rietveld 408576698