[GN] Lint Android resources

[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810
Committed: https://crrev.com/18749bd362a7a8b7f4c1185c838d724dea5fad85
Cr-Commit-Position: refs/heads/master@{#400727}

[mlopatkin, 2016-06-11 18:07:34]

Description was changed from

==========
[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810
==========

to

==========
[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810
==========

[mlopatkin, 2016-06-11 18:07:34]

mlopatkin@yandex-team.ru changed reviewers:
+ agrieve@chromium.org, jbudorick@chromium.org

[mlopatkin, 2016-06-11 18:15:16]

Please take a look. I plan to add other owners to review later when we agree on
the overall approach.

It turns out that it isn't so hard to enforce "no excessive direct dependencies
in libraries" with some hacks in write_build_config.py. I used these hacks to
detect such dependencies and eliminate them but decided not to include it into
this CL.

[agrieve, 2016-06-15 14:26:22]

The CQ bit was checked by agrieve@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-15 14:26:34]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062633002/1

[agrieve, 2016-06-15 14:31:25]

On 2016/06/15 14:26:34, commit-bot: I haz the power wrote:
> Dry run: CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/2062633002/1

lgtm. Love the change that you don't have to depend on android_resources that
are not your own. Thanks for taking this on!

[agrieve, 2016-06-15 14:32:24]

agrieve@chromium.org changed reviewers:
+ brettw@chromium.org

[agrieve, 2016-06-15 14:32:25]

brettw@chromium.org: Please rs BUILD.gn changes.

[commit-bot: I haz the power, 2016-06-15 15:34:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 15:34:48]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-06-15 19:22:01]

lgtm

https://codereview.chromium.org/2062633002/diff/1/build/config/android/rules.gni
File build/config/android/rules.gni (right):

https://codereview.chromium.org/2062633002/diff/1/build/config/android/rules....
build/config/android/rules.gni:718: #   app_as_shared_lib: If true make a
resource package that can be loaded as
Can you document the new arg here?

[mlopatkin, 2016-06-16 11:51:44]

On 2016/06/15 19:22:01, brettw wrote:
> lgtm
> 
>
https://codereview.chromium.org/2062633002/diff/1/build/config/android/rules.gni
> File build/config/android/rules.gni (right):
> 
>
https://codereview.chromium.org/2062633002/diff/1/build/config/android/rules....
> build/config/android/rules.gni:718: #   app_as_shared_lib: If true make a
> resource package that can be loaded as
> Can you document the new arg here?

I'm afraid I don't understand what new arg you are talking about.
"resource_dirs" already exists (and documented) in "android_resources", I just
forward it to the internal "write_build_config". Could you please clarify?

[agrieve, 2016-06-20 14:07:28]

The CQ bit was checked by agrieve@chromium.org

[commit-bot: I haz the power, 2016-06-20 14:07:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062633002/1

[agrieve, 2016-06-20 14:08:02]

On 2016/06/16 11:51:44, mlopatkin wrote:
> On 2016/06/15 19:22:01, brettw wrote:
> > lgtm
> > 
> >
>
https://codereview.chromium.org/2062633002/diff/1/build/config/android/rules.gni
> > File build/config/android/rules.gni (right):
> > 
> >
>
https://codereview.chromium.org/2062633002/diff/1/build/config/android/rules....
> > build/config/android/rules.gni:718: #   app_as_shared_lib: If true make a
> > resource package that can be loaded as
> > Can you document the new arg here?
> 
> I'm afraid I don't understand what new arg you are talking about.
> "resource_dirs" already exists (and documented) in "android_resources", I just
> forward it to the internal "write_build_config". Could you please clarify?

Yeah, I think the comment just fell out of view of the diff window. Going to
land now since I have time to watch bots.

[commit-bot: I haz the power, 2016-06-20 15:23:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-20 15:23:07]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mlopatkin, 2016-06-20 17:43:10]

The CQ bit was checked by mlopatkin@yandex-team.ru

[commit-bot: I haz the power, 2016-06-20 17:43:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2062633002/1

[commit-bot: I haz the power, 2016-06-20 18:13:59]

Description was changed from

==========
[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810
==========

to

==========
[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810
==========

[commit-bot: I haz the power, 2016-06-20 18:14:01]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-20 18:18:59]

Description was changed from

==========
[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810
==========

to

==========
[GN] Lint Android resources

Lint is still run only within android_library/android_apk targets but resources
folders and generated resources ZIPs from direct dependencies are added to this
run. ZIPs are extracted to temporary folders during linting.

This approach requires a big rewrite of existing dependencies. Before the patch
every library that needs to reference something from R.java of the other library
has to directly depend on the resource target that generates this R.java, for
example chrome_java depended on ui_java_resources while also dependening on
ui_java. This is the only way to get R.java from ui_java_resources in
chrome_java. This causes Lint to lint ui_java_resources twice (within
chrome_java and ui_java) and may produce false positives. This patch changes
these R.java dependencies to transitives, so chrome_java only depends on ui_java
and still gets all R.java from its resources.

Only resources that are the part of the library/APK should be direct
dependencies of this library otherwise Lint will not work properly.

Resource folders/ZIPs are propagated to dependent libraries via build_config
files. Each android_resources target publishes its resource folders in its
build_config; it also writes list of resources_zips of direct dependencies which
have no own package names - these are generated resources, conceptually part of
the same target. Library/APK targets expose list of folders and ZIPs from
dependencies via their own build_config which is read by Lint.

BUG=595810

Committed: https://crrev.com/18749bd362a7a8b7f4c1185c838d724dea5fad85
Cr-Commit-Position: refs/heads/master@{#400727}
==========

[commit-bot: I haz the power, 2016-06-20 18:19:00]

Patchset 1 (id:??) landed as
https://crrev.com/18749bd362a7a8b7f4c1185c838d724dea5fad85
Cr-Commit-Position: refs/heads/master@{#400727}