Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2372)

Unified Diff: build/config/android/internal_rules.gni

Issue 2062633002: [GN] Lint Android resources (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/config/android/internal_rules.gni
diff --git a/build/config/android/internal_rules.gni b/build/config/android/internal_rules.gni
index 0b9fa9d12400a017bf48db6fb98a71dcf85ddcb0..549f3d8a67f1ce2f4b285e851c69e847b682d73c 100644
--- a/build/config/android/internal_rules.gni
+++ b/build/config/android/internal_rules.gni
@@ -185,6 +185,11 @@ template("write_build_config") {
}
}
+ if (is_android_resources && defined(invoker.resource_dirs)) {
+ resource_dirs = rebase_path(invoker.resource_dirs, root_build_dir)
+ args += [ "--resource-dirs=$resource_dirs" ]
+ }
+
if (is_apk) {
if (defined(invoker.native_libs)) {
inputs += invoker.native_libs
@@ -523,6 +528,8 @@ if (enable_java_templates) {
rebase_path(invoker.jar_path, root_build_dir),
"--java-files=$_rebased_java_files",
"--classpath=@FileArg($_rebased_build_config:javac:interface_classpath)",
+ "--resource-sources=@FileArg($_rebased_build_config:lint:resources_dirs)",
+ "--resource-sources=@FileArg($_rebased_build_config:lint:resources_zips)",
]
}
}

Powered by Google App Engine
This is Rietveld 408576698