Issue 2069313002: Removed keeps for unused member variables.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2069313002: Removed keeps for unused member variables. (Closed)

Created:
4 years, 6 months ago by agrieve

Modified:
4 years, 6 months ago

Reviewers:

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Removed keeps for unused member variables. Right now, we have a very old Proguard rule that keeps around all unused member variables for seemingly no reason at all. Removing these member variables saves us 260kb in .dex size. BUG=619937 patch from issue 2070633002 at patchset 1 (http://crrev.com/2070633002#ps1)

Patch Set 1 #

Patch Set 2 : test addding R.dex #

Created: 4 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -6 lines)			Patch
	M	build/config/android/rules.gni	View	1	1 chunk	+8 lines, -0 lines	0 comments	Download
	M	chrome/android/java/proguard.flags	View	1	1 chunk	+0 lines, -6 lines	0 comments	Download

Depends on Patchset:

Issue 2062633002 Patch 1