Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 2083683002: 🎄 Refactor: include apk_under_test.jar in full_class_path (and add TODO) (Closed)

Created:
4 years, 6 months ago by agrieve
Modified:
4 years, 6 months ago
Reviewers:
Peter Wen
CC:
chromium-reviews, jbudorick+watch_chromium.org, mikecase+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lint-resources
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor: include apk_under_test.jar in full_class_path (and add TODO) proguard.py filters out the newly added entry, so this change is entirely a no-op. Makes the code a bit more understandable imo. BUG=none Committed: https://crrev.com/c34096a861aad0076fd89975ba97143e8b46135d Cr-Commit-Position: refs/heads/master@{#400772}

Patch Set 1 #

Patch Set 2 : Refactor: include apk_under_test.jar in full_class_path (and add TODO) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -20 lines) Patch
M build/android/gyp/write_build_config.py View 1 2 chunks +25 lines, -20 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
agrieve
On 2016/06/20 17:54:50, agrieve wrote: > The CQ bit was checked by mailto:agrieve@chromium.org to run ...
4 years, 6 months ago (2016-06-20 17:54:56 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083683002/20001
4 years, 6 months ago (2016-06-20 17:55:28 UTC) #5
Peter Wen
lgtm
4 years, 6 months ago (2016-06-20 18:27:38 UTC) #6
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-20 18:52:26 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2083683002/20001
4 years, 6 months ago (2016-06-20 20:39:32 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-20 20:45:18 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-20 20:46:46 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c34096a861aad0076fd89975ba97143e8b46135d
Cr-Commit-Position: refs/heads/master@{#400772}

Powered by Google App Engine
This is Rietveld 408576698