Implement native GMB backbuffers in the GLES2 Command Decoder.

Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
them to use the new CoreAnimation compositor.

* Add a new method to ImageFactory to allow the creation of anonymous images.
* Add logic to BackTexture to allow storage allocation via Image.
* Use existing logic to implement RGB emulation.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7ea4608d71ab856d422381c5fd99920f67b80d23
Cr-Commit-Position: refs/heads/master@{#402387}

[erikchen, 2016-06-14 01:06:27]

Description was changed from

==========
GLES2 temp86_backtexture_gpu_memory_buffer

BUG=
==========

to

==========
GLES2 temp86_backtexture_gpu_memory_buffer

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-14 01:49:01]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-14 01:49:19]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061743004/1

[erikchen, 2016-06-14 01:51:07]

Description was changed from

==========
GLES2 temp86_backtexture_gpu_memory_buffer

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Add plumbing for Native GMB backbuffers in the GLES2 Command Decoder.

This CL creates an interface that allows a client to force the Command Decoder
to use native GMBs for its back buffer.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[commit-bot: I haz the power, 2016-06-14 04:02:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 04:02:09]

Dry run: This issue passed the CQ dry run.

[erikchen, 2016-06-24 00:40:49]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 00:41:28]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061743004/80001

[commit-bot: I haz the power, 2016-06-24 00:47:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 00:47:06]

Dry run: Try jobs failed on following builders:
  android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...)
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)
  android_compile_dbg on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)
  cast_shell_android on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
  cast_shell_linux on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[erikchen, 2016-06-24 00:49:29]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 00:50:24]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061743004/100001

[commit-bot: I haz the power, 2016-06-24 00:54:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 00:54:44]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)

[erikchen, 2016-06-24 01:13:34]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 01:14:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061743004/120001

[commit-bot: I haz the power, 2016-06-24 01:25:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 01:25:58]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-24 18:49:32]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 18:50:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 19:03:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 19:03:33]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-24 20:27:52]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 20:28:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 20:38:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 20:38:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-24 23:23:38]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-24 23:24:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-24 23:32:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-24 23:32:56]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-25 00:11:57]

Description was changed from

==========
Add plumbing for Native GMB backbuffers in the GLES2 Command Decoder.

This CL creates an interface that allows a client to force the Command Decoder
to use native GMBs for its back buffer.

BUG=
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
pepper apps to use the new CoreAnimation compositor.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-25 00:12:04]

Description was changed from

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
pepper apps to use the new CoreAnimation compositor.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
pepper apps to use the new CoreAnimation compositor.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-27 15:52:47]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 15:53:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:02:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:02:25]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-27 16:06:28]

Description was changed from

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
pepper apps to use the new CoreAnimation compositor.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
them to use the new CoreAnimation compositor.

* Add a new method to ImageFactory to allow the creation of anonymous images.
* Add logic to BackTexture to allow storage allocation via Image.
* Use existing logic to implement RGB emulation.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[erikchen, 2016-06-27 16:11:52]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 16:12:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 16:20:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 16:20:17]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-27 18:11:18]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[erikchen, 2016-06-27 18:11:33]

erikchen@chromium.org changed reviewers:
+ piman@chromium.org

[erikchen, 2016-06-27 18:11:34]

piman: Please review.

[commit-bot: I haz the power, 2016-06-27 18:11:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 18:21:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 18:21:43]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[piman, 2016-06-27 19:37:37]

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2410:
glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, targetid);
nit: this was already done on l.2406

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2615: ? GL_TEXTURE_RECTANGLE_ARB
nit: could the target be given by the ImageFactory?

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2624:
decoder_->GetContextGroup()->image_factory()->CreateAnonymousImage(
image_factory could be null.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2626: if
(!image->BindTexImage(Target()))
image could be null if the ImageFactory doesn't support CreateAnonymousImage

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2627: return;
Can we forward the failure, so that we can e.g. lose the context instead of
silently failing?

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2655: 0, 0);
nit: is this necessary? You're about to destroy the fbo.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2744: GL_RENDERBUFFER, 0);
nit: ditto.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2955:
attrib_helper.should_use_native_gmb_for_backbuffer;
We need a check of some sort, somewhere. Right now an untrusted client on any
platform can request that, and we'll start trying to use
GL_TEXTURE_RECTANGLE_ARB (even if not present) and image_factory (even though it
could be NULL or not support CreateAnonymousImage).

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:16867: #if defined(OS_MACOSX)
nit: is this something maybe the ImageFactory could describe?

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/tes...
File gpu/command_buffer/tests/texture_image_factory.cc (right):

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/tes...
gpu/command_buffer/tests/texture_image_factory.cc:15: TextureImage(const
gfx::Size& size) : size_(size) {}
nit: explicit

[erikchen, 2016-06-27 22:16:04]

piman: PTAL

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
File gpu/command_buffer/service/gles2_cmd_decoder.cc (right):

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2410:
glBindFramebufferEXT(GL_DRAW_FRAMEBUFFER_EXT, targetid);
On 2016/06/27 19:37:36, piman wrote:
> nit: this was already done on l.2406

Removed.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2615: ? GL_TEXTURE_RECTANGLE_ARB
On 2016/06/27 19:37:36, piman wrote:
> nit: could the target be given by the ImageFactory?

Yes, Done

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2624:
decoder_->GetContextGroup()->image_factory()->CreateAnonymousImage(
On 2016/06/27 19:37:36, piman wrote:
> image_factory could be null.

This gets DCHECKED in the constructor of BackTexture, and the real logic to
prevent this from happening lies in the Decoder initializer.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2626: if
(!image->BindTexImage(Target()))
On 2016/06/27 19:37:36, piman wrote:
> image could be null if the ImageFactory doesn't support CreateAnonymousImage

Added a conditional.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2627: return;
On 2016/06/27 19:37:36, piman wrote:
> Can we forward the failure, so that we can e.g. lose the context instead of
> silently failing?

Done.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2655: 0, 0);
On 2016/06/27 19:37:36, piman wrote:
> nit: is this necessary? You're about to destroy the fbo.

No, removed.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2744: GL_RENDERBUFFER, 0);
On 2016/06/27 19:37:36, piman wrote:
> nit: ditto.

Done.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:2955:
attrib_helper.should_use_native_gmb_for_backbuffer;
On 2016/06/27 19:37:37, piman wrote:
> We need a check of some sort, somewhere. Right now an untrusted client on any
> platform can request that, and we'll start trying to use
> GL_TEXTURE_RECTANGLE_ARB (even if not present) and image_factory (even though
it
> could be NULL or not support CreateAnonymousImage).

I added a check here. If should_use_native_gmb_for_backbuffer_ is true, then the
new logic checks that an image factory exists, and that the relevant texture
type is supported.

The implementation of BackTexture will handle an unimplemented
CreateAnonymousImage.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/ser...
gpu/command_buffer/service/gles2_cmd_decoder.cc:16867: #if defined(OS_MACOSX)
On 2016/06/27 19:37:36, piman wrote:
> nit: is this something maybe the ImageFactory could describe?

Done.

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/tes...
File gpu/command_buffer/tests/texture_image_factory.cc (right):

https://codereview.chromium.org/2061743004/diff/230001/gpu/command_buffer/tes...
gpu/command_buffer/tests/texture_image_factory.cc:15: TextureImage(const
gfx::Size& size) : size_(size) {}
On 2016/06/27 19:37:37, piman wrote:
> nit: explicit

Done.

[erikchen, 2016-06-27 22:16:19]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 22:16:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-27 22:27:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-27 22:27:56]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-27 22:36:37]

The CQ bit was checked by erikchen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-27 22:37:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[piman, 2016-06-27 22:46:15]

lgtm

https://codereview.chromium.org/2061743004/diff/280001/gpu/command_buffer/ser...
File gpu/command_buffer/service/image_factory.cc (right):

https://codereview.chromium.org/2061743004/diff/280001/gpu/command_buffer/ser...
gpu/command_buffer/service/image_factory.cc:26: NOTREACHED();
nit: this is reached on !mac if the client requests GMB backbuffers.
NOTIMPLEMENTED() instead?

[commit-bot: I haz the power, 2016-06-28 01:27:27]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 01:27:29]

Dry run: Try jobs failed on following builders:
  linux_optional_gpu_tests_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_optional_...)

[erikchen, 2016-06-28 01:38:42]

https://codereview.chromium.org/2061743004/diff/280001/gpu/command_buffer/ser...
File gpu/command_buffer/service/image_factory.cc (right):

https://codereview.chromium.org/2061743004/diff/280001/gpu/command_buffer/ser...
gpu/command_buffer/service/image_factory.cc:26: NOTREACHED();
On 2016/06/27 22:46:15, piman wrote:
> nit: this is reached on !mac if the client requests GMB backbuffers.
> NOTIMPLEMENTED() instead?

Done.

[erikchen, 2016-06-28 01:38:50]

The CQ bit was checked by erikchen@chromium.org

[erikchen, 2016-06-28 01:38:50]

The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org
Link to the patchset: https://codereview.chromium.org/2061743004/#ps300001
(title: "Comments from piman.")

[commit-bot: I haz the power, 2016-06-28 01:39:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 01:49:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-28 01:49:08]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[erikchen, 2016-06-28 02:47:41]

erikchen@chromium.org changed reviewers:
+ fsamuel@chromium.org

[erikchen, 2016-06-28 02:47:42]

fsamuel: Please review components/mus/gles2/command_buffer_driver.cc

[Fady Samuel, 2016-06-28 02:52:50]

mus lgtm

[erikchen, 2016-06-28 03:28:49]

The CQ bit was checked by erikchen@chromium.org

[commit-bot: I haz the power, 2016-06-28 03:29:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-28 03:37:27]

Committed patchset #17 (id:300001)

[commit-bot: I haz the power, 2016-06-28 03:39:03]

Description was changed from

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
them to use the new CoreAnimation compositor.

* Add a new method to ImageFactory to allow the creation of anonymous images.
* Add logic to BackTexture to allow storage allocation via Image.
* Use existing logic to implement RGB emulation.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Implement native GMB backbuffers in the GLES2 Command Decoder.

This will allow pepper apps to draw directly into a native GMB, which allows
them to use the new CoreAnimation compositor.

* Add a new method to ImageFactory to allow the creation of anonymous images.
* Add logic to BackTexture to allow storage allocation via Image.
* Use existing logic to implement RGB emulation.

BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel

Committed: https://crrev.com/7ea4608d71ab856d422381c5fd99920f67b80d23
Cr-Commit-Position: refs/heads/master@{#402387}
==========

[commit-bot: I haz the power, 2016-06-28 03:39:05]

Patchset 17 (id:??) landed as
https://crrev.com/7ea4608d71ab856d422381c5fd99920f67b80d23
Cr-Commit-Position: refs/heads/master@{#402387}