Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Issue 2103913002: Change destruction order of GLES2CmdDecoder. (Closed)

Created:
4 years, 5 months ago by erikchen
Modified:
4 years, 5 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp73_backbuffer
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change destruction order of GLES2CmdDecoder. Previously, ContextState was destroyed before internal state. Some internal state (such as BackTexture) require ContextState to still be around before they are destroyed. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4f2b6a831fd34e728b87e3797686e70983a748a9 Cr-Commit-Position: refs/heads/master@{#402547}

Patch Set 1 #

Patch Set 2 : Add DCHECK. #

Patch Set 3 : Remove DCHECK. Causes WebGL2 failures. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -19 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 2 2 chunks +19 lines, -19 lines 0 comments Download

Messages

Total messages: 29 (15 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/1
4 years, 5 months ago (2016-06-28 15:28:32 UTC) #3
erikchen
piman: Please review.
4 years, 5 months ago (2016-06-28 15:36:02 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/20001
4 years, 5 months ago (2016-06-28 15:36:05 UTC) #7
piman
lgtm
4 years, 5 months ago (2016-06-28 15:39:09 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/20001
4 years, 5 months ago (2016-06-28 15:44:53 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/253792)
4 years, 5 months ago (2016-06-28 17:09:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/20001
4 years, 5 months ago (2016-06-28 17:55:47 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/40001
4 years, 5 months ago (2016-06-28 18:31:01 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/1554)
4 years, 5 months ago (2016-06-28 19:51:18 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/40001
4 years, 5 months ago (2016-06-28 19:53:14 UTC) #22
commit-bot: I haz the power
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_tests_rel/builds/1561)
4 years, 5 months ago (2016-06-28 19:59:49 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2103913002/40001
4 years, 5 months ago (2016-06-28 20:32:51 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 5 months ago (2016-06-28 21:25:31 UTC) #27
commit-bot: I haz the power
4 years, 5 months ago (2016-06-28 21:27:05 UTC) #29
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f2b6a831fd34e728b87e3797686e70983a748a9
Cr-Commit-Position: refs/heads/master@{#402547}

Powered by Google App Engine
This is Rietveld 408576698