|
|
Chromium Code Reviews
DescriptionChange destruction order of GLES2CmdDecoder.
Previously, ContextState was destroyed before internal state. Some internal
state (such as BackTexture) require ContextState to still be around before they
are destroyed.
BUG=602484
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
Committed: https://crrev.com/4f2b6a831fd34e728b87e3797686e70983a748a9
Cr-Commit-Position: refs/heads/master@{#402547}
Patch Set 1 #Patch Set 2 : Add DCHECK. #Patch Set 3 : Remove DCHECK. Causes WebGL2 failures. #Messages
Total messages: 29 (15 generated)
Description was changed from ========== Change destruction order of GLES2CmdDecoder. Previously, ContextState was destroyed before internal state. Some internal state (such as BackTexture) require ContextState to still be around before they are destroyed. BUG=602484 ========== to ========== Change destruction order of GLES2CmdDecoder. Previously, ContextState was destroyed before internal state. Some internal state (such as BackTexture) require ContextState to still be around before they are destroyed. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ==========
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by erikchen@chromium.org to run a CQ dry run
erikchen@chromium.org changed reviewers: + piman@chromium.org
piman: Please review.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by erikchen@chromium.org
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was checked by erikchen@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from piman@chromium.org Link to the patchset: https://codereview.chromium.org/2103913002/#ps40001 (title: "Remove DCHECK. Causes WebGL2 failures.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_optional_gpu_tests_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_optional_gpu_...)
The CQ bit was checked by erikchen@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== Change destruction order of GLES2CmdDecoder. Previously, ContextState was destroyed before internal state. Some internal state (such as BackTexture) require ContextState to still be around before they are destroyed. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel ========== to ========== Change destruction order of GLES2CmdDecoder. Previously, ContextState was destroyed before internal state. Some internal state (such as BackTexture) require ContextState to still be around before they are destroyed. BUG=602484 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/4f2b6a831fd34e728b87e3797686e70983a748a9 Cr-Commit-Position: refs/heads/master@{#402547} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/4f2b6a831fd34e728b87e3797686e70983a748a9 Cr-Commit-Position: refs/heads/master@{#402547} |
