Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(172)

Issue 2061193003: Remove "BUBBLE" from chooser related string IDs (Closed)

Created:
4 years, 6 months ago by juncai
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, extensions-reviews_chromium.org, msramek+watch_chromium.org, tfarina, raymes+watch_chromium.org, chromium-apps-reviews_chromium.org, markusheintz_
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove "BUBBLE" from chooser related string IDs Since these chooser related strings are used by both bubble and dialog, removing "BUBBLE" from them makes it more precise for where they are used. BUG=613598 Committed: https://crrev.com/4e01931c1541fdd1d9ad1521cc120f5cd30d189a Cr-Commit-Position: refs/heads/master@{#399822}

Patch Set 1 : removed "BUBBLE" from chooser related string IDs #

Patch Set 2 : rebase #

Total comments: 6

Patch Set 3 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -31 lines) Patch
M chrome/app/generated_resources.grd View 1 2 1 chunk +7 lines, -12 lines 0 comments Download
M chrome/browser/ui/cocoa/chooser_content_view_cocoa.mm View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/chooser_content_view.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/chooser_content_view_unittest.cc View 1 2 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
juncai
Please take a look.
4 years, 6 months ago (2016-06-14 21:36:36 UTC) #3
msw
https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_resources.grd#newcode14824 chrome/app/generated_resources.grd:14824: + <!-- Chooser Prompt --> "Chooser" is vague, and ...
4 years, 6 months ago (2016-06-14 21:50:24 UTC) #4
juncai
https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_resources.grd#newcode14824 chrome/app/generated_resources.grd:14824: + <!-- Chooser Prompt --> On 2016/06/14 21:50:24, msw ...
4 years, 6 months ago (2016-06-14 22:36:51 UTC) #5
msw
lgtm
4 years, 6 months ago (2016-06-14 22:43:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061193003/40001
4 years, 6 months ago (2016-06-14 22:45:10 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL) ios-device-gn on ...
4 years, 6 months ago (2016-06-15 00:34:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061193003/40001
4 years, 6 months ago (2016-06-15 00:39:49 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-15 02:37:48 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-15 02:37:58 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-15 02:39:12 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4e01931c1541fdd1d9ad1521cc120f5cd30d189a
Cr-Commit-Position: refs/heads/master@{#399822}

Powered by Google App Engine
This is Rietveld 408576698