Remove "BUBBLE" from chooser related string IDs

Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
removing "BUBBLE" from them makes it more precise for where they are used.

BUG=613598
Committed: https://crrev.com/4e01931c1541fdd1d9ad1521cc120f5cd30d189a
Cr-Commit-Position: refs/heads/master@{#399822}

[juncai, 2016-06-14 17:43:02]

Description was changed from

==========
Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
remove "BUBBLE" from them make it more precise for where they are used.

BUG=613598
==========

to

==========
Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
removing "BUBBLE" from them makes it more precise for where they are used.

BUG=613598
==========

[juncai, 2016-06-14 21:36:35]

juncai@chromium.org changed reviewers:
+ msw@chromium.org

[juncai, 2016-06-14 21:36:36]

Please take a look.

[msw, 2016-06-14 21:50:24]

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14824: +      <!-- Chooser Prompt -->
"Chooser" is vague, and this UI component is partially specialized for devices.
WDYT about using "Device Chooser" if you're renaming these strings?

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14828: +      <!-- Chooser No Devices Found
Prompt -->
nit: just remove these redundant comments; comments are elsewhere mainly used to
annotate categories of related strings. (ie. this whole collection of strings
could simply have one "<!-- Device Chooser Prompt -->" category comment)

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14829: +      <message
name="IDS_CHOOSER_NO_DEVICES_FOUND_PROMPT" desc="The label that is used to
inform user that no devices found in the chooser popup.">
nit: "the user", "devices were found"

[juncai, 2016-06-14 22:36:51]

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14824: +      <!-- Chooser Prompt -->
On 2016/06/14 21:50:24, msw wrote:
> "Chooser" is vague, and this UI component is partially specialized for
devices.
> WDYT about using "Device Chooser" if you're renaming these strings?

Done.

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14828: +      <!-- Chooser No Devices Found
Prompt -->
On 2016/06/14 21:50:24, msw wrote:
> nit: just remove these redundant comments; comments are elsewhere mainly used
to
> annotate categories of related strings. (ie. this whole collection of strings
> could simply have one "<!-- Device Chooser Prompt -->" category comment)

Done.

https://codereview.chromium.org/2061193003/diff/20001/chrome/app/generated_re...
chrome/app/generated_resources.grd:14829: +      <message
name="IDS_CHOOSER_NO_DEVICES_FOUND_PROMPT" desc="The label that is used to
inform user that no devices found in the chooser popup.">
On 2016/06/14 21:50:24, msw wrote:
> nit: "the user", "devices were found"

Done.

[msw, 2016-06-14 22:43:04]

lgtm

[juncai, 2016-06-14 22:44:28]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-06-14 22:45:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061193003/40001

[commit-bot: I haz the power, 2016-06-15 00:34:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-15 00:34:04]

Try jobs failed on following builders:
  ios-device on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)
  ios-device-gn on tryserver.chromium.mac (JOB_TIMED_OUT, no build URL)

[juncai, 2016-06-15 00:39:09]

The CQ bit was checked by juncai@chromium.org

[commit-bot: I haz the power, 2016-06-15 00:39:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2061193003/40001

[commit-bot: I haz the power, 2016-06-15 02:37:47]

Description was changed from

==========
Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
removing "BUBBLE" from them makes it more precise for where they are used.

BUG=613598
==========

to

==========
Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
removing "BUBBLE" from them makes it more precise for where they are used.

BUG=613598
==========

[commit-bot: I haz the power, 2016-06-15 02:37:48]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-15 02:37:58]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-15 02:39:11]

Description was changed from

==========
Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
removing "BUBBLE" from them makes it more precise for where they are used.

BUG=613598
==========

to

==========
Remove "BUBBLE" from chooser related string IDs

Since these chooser related strings are used by both bubble and dialog,
removing "BUBBLE" from them makes it more precise for where they are used.

BUG=613598

Committed: https://crrev.com/4e01931c1541fdd1d9ad1521cc120f5cd30d189a
Cr-Commit-Position: refs/heads/master@{#399822}
==========

[commit-bot: I haz the power, 2016-06-15 02:39:12]

Patchset 3 (id:??) landed as
https://crrev.com/4e01931c1541fdd1d9ad1521cc120f5cd30d189a
Cr-Commit-Position: refs/heads/master@{#399822}