chrome/app/generated_resources.grd

Index: chrome/app/generated_resources.grd
diff --git a/chrome/app/generated_resources.grd b/chrome/app/generated_resources.grd
index 87f1ff499b63f82913e282978205e1258b7a3785..1d9c89ec6fc29d9964d586ed5d8400bb64f42f72 100644
--- a/chrome/app/generated_resources.grd
+++ b/chrome/app/generated_resources.grd
@@ -14821,28 +14821,28 @@ Please check your email at <ph name="ACCOUNT_EMAIL">$2<ex>jane.doe@gmail.com</ex
     </if>
 
     <if expr="not is_android and not is_ios">
-      <!-- Chooser Bubble Prompt -->
-      <message name="IDS_CHOOSER_BUBBLE_PROMPT" desc="The label that is used to introduce chooser details to the user in a popup.">
+      <!-- Chooser Prompt -->

[msw, 2016/06/14 21:50:24]

"Chooser" is vague, and this UI component is partially specialized for devices.
WDYT about using "Device Chooser" if you're renaming these strings?

[juncai, 2016/06/14 22:36:50]

Done.

+      <message name="IDS_CHOOSER_PROMPT" desc="The label that is used to introduce chooser details to the user in a popup.">
         <ph name="Origin">$1<ex>www.google.com</ex></ph> wants to connect to:
       </message>
-      <!-- Chooser Bubble No Devices Found Prompt -->
-      <message name="IDS_CHOOSER_BUBBLE_NO_DEVICES_FOUND_PROMPT" desc="The label that is used to inform user that no devices found in the chooser popup.">
+      <!-- Chooser No Devices Found Prompt -->

[msw, 2016/06/14 21:50:24]

nit: just remove these redundant comments; comments are elsewhere mainly used to
annotate categories of related strings. (ie. this whole collection of strings
could simply have one "<!-- Device Chooser Prompt -->" category comment)

[juncai, 2016/06/14 22:36:50]

Done.

+      <message name="IDS_CHOOSER_NO_DEVICES_FOUND_PROMPT" desc="The label that is used to inform user that no devices found in the chooser popup.">

[msw, 2016/06/14 21:50:24]

nit: "the user", "devices were found"

[juncai, 2016/06/14 22:36:50]

Done.

         No devices found.
       </message>
-      <!-- Chooser Bubble Connect Button Text -->
-      <message name="IDS_CHOOSER_BUBBLE_CONNECT_BUTTON_TEXT" desc="The text that is shown on the connect button in the chooser popup.">
+      <!-- Chooser Connect Button Text -->
+      <message name="IDS_CHOOSER_CONNECT_BUTTON_TEXT" desc="The text that is shown on the connect button in the chooser popup.">
         Connect
       </message>
-      <!-- Chooser Bubble Cancel Button Text -->
-      <message name="IDS_CHOOSER_BUBBLE_CANCEL_BUTTON_TEXT" desc="The text that is shown on the cancel button in the chooser popup.">
+      <!-- Chooser Cancel Button Text -->
+      <message name="IDS_CHOOSER_CANCEL_BUTTON_TEXT" desc="The text that is shown on the cancel button in the chooser popup.">
         Cancel
       </message>
-      <!-- Chooser Bubble Footnote Text -->
-      <message name="IDS_CHOOSER_BUBBLE_FOOTNOTE_TEXT" desc="This text is shown at the bottom of the chooser popup with a link to part of its text.">
+      <!-- Chooser Footnote Text -->
+      <message name="IDS_CHOOSER_FOOTNOTE_TEXT" desc="This text is shown at the bottom of the chooser popup with a link to part of its text.">
         Not seeing your device? <ph name="GET_HELP_LINK">$1<ex>Get help</ex></ph>
       </message>
-      <!-- Chooser Bubble Get Help Link Text -->
-      <message name="IDS_CHOOSER_BUBBLE_GET_HELP_LINK_TEXT" desc="Text of the 'Get help' link at the bottom of the chooser popup.">
+      <!-- Chooser Get Help Link Text -->
+      <message name="IDS_CHOOSER_GET_HELP_LINK_TEXT" desc="Text of the 'Get help' link at the bottom of the chooser popup.">
         Get help
       </message>
     </if>