chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm - Issue 2061193003: Remove "BUBBLE" from chooser related string IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

Issue 2061193003: Remove "BUBBLE" from chooser related string IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/extensions/chooser_dialog_cocoa_controller.mm ('k') | chrome/browser/ui/views/chooser_content_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

diff --git a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

index bb17f8bf654ef5b4b7d679833211eee851f49386..ba063bfdfefadd2a363daa042a6502ec0f6f4d44 100644

--- a/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

+++ b/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm

@@ -171,7 +171,7 @@ std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {

chooserContentView_.reset([[ChooserContentViewCocoa alloc]

initWithChooserTitle:

l10n_util::GetNSStringF(

- IDS_CHOOSER_BUBBLE_PROMPT,

+ IDS_DEVICE_CHOOSER_PROMPT,

url_formatter::FormatOriginForSecurityDisplay(

chooserController_->GetOrigin(),

url_formatter::SchemeDisplay::OMIT_CRYPTOGRAPHIC))]);

@@ -228,7 +228,7 @@ std::unique_ptr<BubbleUi> ChooserBubbleDelegate::BuildBubbleUi() {

static_cast<NSInteger>(chooserController_->NumOptions());

if (num_options == 0) {

DCHECK_EQ(0, rowIndex);

- return l10n_util::GetNSString(IDS_CHOOSER_BUBBLE_NO_DEVICES_FOUND_PROMPT);

+ return l10n_util::GetNSString(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT);

}

DCHECK_GE(rowIndex, 0);