chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc - Issue 2061193003: Remove "BUBBLE" from chooser related string IDs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

Issue 2061193003: Remove "BUBBLE" from chooser related string IDs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: address comments Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/extensions/chooser_dialog_view.cc ('k') | chrome/browser/ui/views/website_settings/chooser_bubble_ui_view.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

diff --git a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

index 7f5e86257ef2c7b9ac727106bb0a7a37076805b2..2bcd1c693094e371c4dfba6bea7b37c460481f2e 100644

--- a/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

+++ b/chrome/browser/ui/views/extensions/chooser_dialog_view_browsertest.cc

@@ -48,7 +48,7 @@ IN_PROC_BROWSER_TEST_F(ChooserDialogViewTest, InitialState) {

EXPECT_EQ(table_view_->RowCount(), 1);

EXPECT_EQ(

table_model_->GetText(0, 0),

- l10n_util::GetStringUTF16(IDS_CHOOSER_BUBBLE_NO_DEVICES_FOUND_PROMPT));

+ l10n_util::GetStringUTF16(IDS_DEVICE_CHOOSER_NO_DEVICES_FOUND_PROMPT));

// |table_view_| should be disabled since there is no option shown.

EXPECT_FALSE(table_view_->enabled());

// No option selected.