Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

gc plugin: remove ScriptWrappable destructor special case. With Blink having exited its Oilpan transition phase, no need for the plugin to catch & allow GarbageCollected<>-derived classes that also derive from ScriptWrappable (but could safely not provide a destructor.) Remove the unused IsRawPtr(name), IsDummyBase(name) predicates, as well. R= BUG= Committed: https://crrev.com/42ba07774c03d438c4423f12a32c3d7edbb1037b Cr-Commit-Position: refs/heads/master@{#399667}

Patch Set 1 #

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-14 07:48:09 UTC) #2
haraken
LGTM
4 years, 6 months ago (2016-06-14 07:56:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2061143002/1
4 years, 6 months ago (2016-06-14 08:09:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-14 08:21:23 UTC) #6
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 08:22:35 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/42ba07774c03d438c4423f12a32c3d7edbb1037b
Cr-Commit-Position: refs/heads/master@{#399667}

Powered by Google App Engine
This is Rietveld 408576698