tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt - Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.txt

Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_base.cpp ('k') | tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 In file included from class_requires_finalization_base.cpp:5:	1 In file included from class_requires_finalization_base.cpp:5:

2 ./class_requires_finalization_base.h:23:1: warning: [blink-gc] Class 'NeedsFinal izer' requires finalization.	2 ./class_requires_finalization_base.h:23:1: warning: [blink-gc] Class 'NeedsFinal izer' requires finalization.

3 class NeedsFinalizer : public A, public B {	3 class NeedsFinalizer : public A, public B {

4 ^	4 ^

5 ./class_requires_finalization_base.h:23:34: note: [blink-gc] Base class 'B' requ iring finalization declared here:	5 ./class_requires_finalization_base.h:23:34: note: [blink-gc] Base class 'B' requ iring finalization declared here:

6 class NeedsFinalizer : public A, public B {	6 class NeedsFinalizer : public A, public B {

7 ^	7 ^

8 ./class_requires_finalization_base.h:40:1: warning: [blink-gc] Class 'GCedClassW ithAScriptWrappableAndAFinalizableBase' requires finalization.	8 1 warning generated.

9 class GCedClassWithAScriptWrappableAndAFinalizableBase

10 ^

11 ./class_requires_finalization_base.h:42:7: note: [blink-gc] Base class 'B' requi ring finalization declared here:

12 , public B

13 ^

14 2 warnings generated.

OLD	NEW