tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h - Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/clang/blink_gc_plugin/tests/class_requires_finalization_field.txt ('k') | tools/clang/blink_gc_plugin/tests/heap/stubs.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

diff --git a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

index 929785d7ad04fe23a62afcf67f5d3bd145e950a5..10befbd9e848643fbe53d98e2f8336f9eeb76cd3 100644

--- a/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

+++ b/tools/clang/blink_gc_plugin/tests/class_requires_finalization_mixin.h

@@ -48,8 +48,7 @@ private:

class NeedsNoFinalization

: public GarbageCollected<NeedsNoFinalization>

- , public MixinNotFinalizable

- , public ScriptWrappable {

+ , public MixinNotFinalizable {

USING_GARBAGE_COLLECTED_MIXIN(NeedsNoFinalization);

public:

virtual void trace(Visitor*) override;