Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(63)

Unified Diff: tools/clang/blink_gc_plugin/Config.h

Issue 2061143002: gc plugin: remove ScriptWrappable destructor special case. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/RecordInfo.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/blink_gc_plugin/Config.h
diff --git a/tools/clang/blink_gc_plugin/Config.h b/tools/clang/blink_gc_plugin/Config.h
index 8d331e5581e13e0fdef6e494ae5bc6c7c900dc5a..53e52214de15e49915a854ca95c85bb8e4c984a6 100644
--- a/tools/clang/blink_gc_plugin/Config.h
+++ b/tools/clang/blink_gc_plugin/Config.h
@@ -57,10 +57,6 @@ class Config {
IsPersistentGCCollection(name);
}
- static bool IsRawPtr(const std::string& name) {
- return name == "RawPtr";
- }
-
static bool IsRefPtr(const std::string& name) {
return name == "RefPtr";
}
@@ -106,23 +102,11 @@ class Config {
name == "PersistentHeapHashMap";
}
- // Following http://crrev.com/369633033 (Blink r177436),
- // ignore blink::ScriptWrappable's destructor.
- // TODO: remove when its non-Oilpan destructor is removed.
- static bool HasIgnorableDestructor(const std::string& ns,
- const std::string& name) {
- return ns == "blink" && name == "ScriptWrappable";
- }
-
// Assumes name is a valid collection name.
static size_t CollectionDimension(const std::string& name) {
return (IsHashMap(name) || name == "pair") ? 2 : 1;
}
- static bool IsDummyBase(const std::string& name) {
- return name == "DummyBase";
- }
-
static bool IsRefCountedBase(const std::string& name) {
return name == "RefCounted" ||
name == "ThreadSafeRefCounted";
@@ -145,7 +129,7 @@ class Config {
// Returns true of the base classes that do not need a vtable entry for trace
// because they cannot possibly initiate a GC during construction.
static bool IsSafePolymorphicBase(const std::string& name) {
- return IsGCBase(name) || IsDummyBase(name) || IsRefCountedBase(name);
+ return IsGCBase(name) || IsRefCountedBase(name);
}
static bool IsAnnotated(clang::Decl* decl, const std::string& anno) {
« no previous file with comments | « no previous file | tools/clang/blink_gc_plugin/RecordInfo.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698