Default components to static libraries in GN build

Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test targets link large components in chrome but use almost none of them, and including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and https://codereview.chromium.org/2063483002 but disabled for official Windows builds.

In support of the official condition, is_official_build moved to BUILDCONFIG. Since this is really a different level of debug/release, this may actually make more sense. The documentation around this was enhanced a lot, official now automatically turns off debug, and it will assert if you override both to produce an official debug build.

BUG=617837
Committed: https://crrev.com/022f8f346d72007cf75469299f894ad4edfda5a8
Cr-Commit-Position: refs/heads/master@{#399633}

[brettw, 2016-06-13 18:13:08]

Description was changed from

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

TBR=brucedawson
BUG=617837
==========

to

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

BUG=617837
==========

[brettw, 2016-06-13 18:13:09]

brettw@chromium.org changed reviewers:
+ dpranke@chromium.org
- brucedawson@chromium.org

[brettw, 2016-06-13 18:13:15]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-13 18:14:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060983002/20001

[brettw, 2016-06-13 18:22:14]

Description was changed from

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

BUG=617837
==========

to

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

In support of the official condition, is_official_build moved to BUILDCONFIG.
Since this is really a different level of debug/release, this may actually make
more sense. The documentation around this was enhanced a lot, official now
automatically turns off debug, and it will assert if you override both to
produce an official debug build.

BUG=617837
==========

[Dirk Pranke, 2016-06-13 19:43:37]

lgtm

https://codereview.chromium.org/2060983002/diff/20001/base/BUILD.gn
File base/BUILD.gn (right):

https://codereview.chromium.org/2060983002/diff/20001/base/BUILD.gn#newcode129
base/BUILD.gn:129: # hacl_helper_nonsfi doesn't link properly on Linux in debug
builds. The
typo: "nacl_helper_nonsfi".

https://codereview.chromium.org/2060983002/diff/20001/build/config/BUILDCONFI...
File build/config/BUILDCONFIG.gn (right):

https://codereview.chromium.org/2060983002/diff/20001/build/config/BUILDCONFI...
build/config/BUILDCONFIG.gn:634: # causes lib.exe to fail. Always use source
sets for that configuration.
this allows us to avoid msvs_shard?

[brettw, 2016-06-13 20:08:50]

typo

[brettw, 2016-06-13 20:08:52]

The CQ bit was checked by brettw@chromium.org

[brettw, 2016-06-13 20:08:53]

The patchset sent to the CQ was uploaded after l-g-t-m from dpranke@chromium.org
Link to the patchset: https://codereview.chromium.org/2060983002/#ps40001
(title: "typo")

[commit-bot: I haz the power, 2016-06-13 20:09:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060983002/40001

[commit-bot: I haz the power, 2016-06-14 00:03:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-14 00:03:49]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[brettw, 2016-06-14 00:20:11]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-06-14 00:21:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2060983002/40001

[commit-bot: I haz the power, 2016-06-14 01:22:54]

Description was changed from

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

In support of the official condition, is_official_build moved to BUILDCONFIG.
Since this is really a different level of debug/release, this may actually make
more sense. The documentation around this was enhanced a lot, official now
automatically turns off debug, and it will assert if you override both to
produce an official debug build.

BUG=617837
==========

to

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

In support of the official condition, is_official_build moved to BUILDCONFIG.
Since this is really a different level of debug/release, this may actually make
more sense. The documentation around this was enhanced a lot, official now
automatically turns off debug, and it will assert if you override both to
produce an official debug build.

BUG=617837
==========

[commit-bot: I haz the power, 2016-06-14 01:22:55]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-06-14 01:23:05]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 01:25:01]

Description was changed from

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

In support of the official condition, is_official_build moved to BUILDCONFIG.
Since this is really a different level of debug/release, this may actually make
more sense. The documentation around this was enhanced a lot, official now
automatically turns off debug, and it will assert if you override both to
produce an official debug build.

BUG=617837
==========

to

==========
Default components to static libraries in GN build

Previously components would be source sets in non-component mode. Some test
targets link large components in chrome but use almost none of them, and
including all object files makes these links very slow.

Reland of https://codereview.chromium.org/2043873004/ and
https://codereview.chromium.org/2063483002 but disabled for official Windows
builds.

In support of the official condition, is_official_build moved to BUILDCONFIG.
Since this is really a different level of debug/release, this may actually make
more sense. The documentation around this was enhanced a lot, official now
automatically turns off debug, and it will assert if you override both to
produce an official debug build.

BUG=617837

Committed: https://crrev.com/022f8f346d72007cf75469299f894ad4edfda5a8
Cr-Commit-Position: refs/heads/master@{#399633}
==========

[commit-bot: I haz the power, 2016-06-14 01:25:03]

Patchset 3 (id:??) landed as
https://crrev.com/022f8f346d72007cf75469299f894ad4edfda5a8
Cr-Commit-Position: refs/heads/master@{#399633}

[picksi1, 2016-06-15 14:54:09]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/2071493002/ by picksi@chromium.org.

The reason for reverting is: Build broken:
https://build.chromium.org/p/chromium.perf/builders/Win%20x64%20Builder

See https://bugs.chromium.org/p/chromium/issues/detail?id=619949
For recommendation to revert..