Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5527)

Unified Diff: chrome/browser/ui/BUILD.gn

Issue 2060983002: Default components to static libraries in GN build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/BUILD.gn
diff --git a/chrome/browser/ui/BUILD.gn b/chrome/browser/ui/BUILD.gn
index 99b16a7621793f55fad15b7e1ce0fbbd063d5c4e..9682156955f3edf46832f0b5e8d45edb8a704597 100644
--- a/chrome/browser/ui/BUILD.gn
+++ b/chrome/browser/ui/BUILD.gn
@@ -19,7 +19,17 @@ config("ui_warnings") {
}
}
-source_set("ui") {
+# Use a static library here because many test binaries depend on this but don't
+# require many files from it. This makes linking more efficient.
+if (is_mac) {
+ # TODO(brettw) bug 618797: On Mac making this target a static_library causes
+ # a crash on startup and the browser_tests all fail. My guess is this is due
+ # to a required static initializer not being brought in.
+ chrome_browser_target_type = "source_set"
+} else {
+ chrome_browser_target_type = "static_library"
+}
+target(chrome_browser_target_type, "ui") {
sources = []
defines = []
libs = []
« no previous file with comments | « chrome/browser/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698