Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(460)

Issue 2063483002: Make chrome/browser and .../ui static libraries. (Closed)

Created:
4 years, 6 months ago by brettw
Modified:
4 years, 6 months ago
Reviewers:
dpranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make chrome/browser and .../ui static libraries. On Windows this seems to make some tests link faster because the tests link to these larget targets but don't use most of them. The static library is much more efficient to link in this case since only the required compilation units are loaded. TBR=dpranke (split off of https://codereview.chromium.org/2043873004/ which already has review) BUG=617837 Committed: https://crrev.com/2f95a3fb1773f911ca05c26cbacaecc537bd9e31 Cr-Commit-Position: refs/heads/master@{#399401}

Patch Set 1 #

Patch Set 2 : format #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +11 lines, -1 line 0 comments Download
M chrome/browser/ui/BUILD.gn View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
brettw
4 years, 6 months ago (2016-06-10 21:52:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063483002/1
4 years, 6 months ago (2016-06-10 21:53:04 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_rel/builds/125961)
4 years, 6 months ago (2016-06-11 00:39:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2063483002/20001
4 years, 6 months ago (2016-06-13 00:19:22 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 01:04:06 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/2f95a3fb1773f911ca05c26cbacaecc537bd9e31 Cr-Commit-Position: refs/heads/master@{#399401}
4 years, 6 months ago (2016-06-13 01:06:30 UTC) #10
fmeawad
4 years, 6 months ago (2016-06-13 16:01:43 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2061773002/ by fmeawad@chromium.org.

The reason for reverting is: Breaking Win x64 Perf builder (official)

Speculative.

BUG=619606.

Powered by Google App Engine
This is Rietveld 408576698