Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(796)

Side by Side Diff: base/BUILD.gn

Issue 2060983002: Default components to static libraries in GN build (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: typo Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # HOW TO WRITE CONDITIONALS IN THIS FILE 5 # HOW TO WRITE CONDITIONALS IN THIS FILE
6 # ====================================== 6 # ======================================
7 # 7 #
8 # In many other places, one would write a conditional that expresses all the 8 # In many other places, one would write a conditional that expresses all the
9 # cases when a source file is used or unused, and then either add or subtract 9 # cases when a source file is used or unused, and then either add or subtract
10 # it from the sources list in that case 10 # it from the sources list in that case
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 # few static initializers floating around means that dead code stripping 117 # few static initializers floating around means that dead code stripping
118 # still leaves a lot of code behind that isn't always used. For example, this 118 # still leaves a lot of code behind that isn't always used. For example, this
119 # saves more than 40K for a smaller target like chrome_elf. 119 # saves more than 40K for a smaller target like chrome_elf.
120 # 120 #
121 # Use static libraries for the helper stuff as well like //base/debug since 121 # Use static libraries for the helper stuff as well like //base/debug since
122 # those things refer back to base code, which will force base compilation units 122 # those things refer back to base code, which will force base compilation units
123 # to be linked in where they wouldn't have otherwise. This does not include 123 # to be linked in where they wouldn't have otherwise. This does not include
124 # test code (test support and anything in the test directory) which should use 124 # test code (test support and anything in the test directory) which should use
125 # source_set as is recommended for GN targets). 125 # source_set as is recommended for GN targets).
126 component("base") { 126 component("base") {
127 # TODO(phosek) bug 570839: If field_trial.cc is in a static library, 127 if (is_nacl_nonsfi) {
128 # hacl_helper_nonsfi doesn't link properly on Linux in debug builds. The 128 # TODO(phosek) bug 570839: If field_trial.cc is in a static library,
129 # reasons for this seem to involve obscure toolchain bugs. This should be 129 # nacl_helper_nonsfi doesn't link properly on Linux in debug builds. The
130 # fixed and this target should always be a static_library in the 130 # reasons for this seem to involve obscure toolchain bugs. This should be
131 # non-component case. 131 # fixed and this target should always be a static_library in the
132 component_never_use_source_set = !is_nacl_nonsfi 132 # non-component case.
133 static_component_type = "source_set"
134 }
133 135
134 sources = [ 136 sources = [
135 "allocator/allocator_check.cc", 137 "allocator/allocator_check.cc",
136 "allocator/allocator_check.h", 138 "allocator/allocator_check.h",
137 "allocator/allocator_extension.cc", 139 "allocator/allocator_extension.cc",
138 "allocator/allocator_extension.h", 140 "allocator/allocator_extension.h",
139 "android/animation_frame_time_histogram.cc", 141 "android/animation_frame_time_histogram.cc",
140 "android/animation_frame_time_histogram.h", 142 "android/animation_frame_time_histogram.h",
141 "android/apk_assets.cc", 143 "android/apk_assets.cc",
142 "android/apk_assets.h", 144 "android/apk_assets.h",
(...skipping 2246 matching lines...) Expand 10 before | Expand all | Expand 10 after
2389 2391
2390 # GYP: //base.gyp:base_java_unittest_support 2392 # GYP: //base.gyp:base_java_unittest_support
2391 android_library("base_java_unittest_support") { 2393 android_library("base_java_unittest_support") {
2392 deps = [ 2394 deps = [
2393 ":base_java", 2395 ":base_java",
2394 ] 2396 ]
2395 java_files = 2397 java_files =
2396 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ] 2398 [ "test/android/java/src/org/chromium/base/ContentUriTestUtils.java" ]
2397 } 2399 }
2398 } 2400 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698