gn: Remove unnecessary v8 defaults

gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Committed: https://crrev.com/d65ec5c9df401b4a60c6a57b2c9d5a539fe9191d
Cr-Original-Commit-Position: refs/heads/master@{#406067}
Cr-Commit-Position: refs/heads/master@{#407106}

[Michael Achenbach, 2016-06-10 10:20:08]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

BUG=
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
==========

[Michael Achenbach, 2016-06-10 10:20:08]

machenbach@chromium.org changed reviewers:
+ dpranke@chromium.org, jochen@chromium.org, vogelheim@chromium.org

[Michael Achenbach, 2016-06-10 10:20:14]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[Michael Achenbach, 2016-06-10 10:20:21]

PTAL

[commit-bot: I haz the power, 2016-06-10 10:20:30]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2058033002/1

[commit-bot: I haz the power, 2016-06-10 10:23:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 10:23:01]

Dry run: Try jobs failed on following builders:
  ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
  ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
  mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

[Michael Achenbach, 2016-06-10 10:55:31]

On 2016/06/10 10:23:01, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   ios-device-gn on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...)
>   ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
>   mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...)

Hum - some files don't include the v8.gni. Will work on that...

[jochen (gone - plz use gerrit), 2016-06-13 15:23:13]

lgtm

[Michael Achenbach, 2016-07-18 12:49:31]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-18 12:49:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 13:45:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 13:45:21]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-18 13:57:08]

All green. Patch 7 still ok?

[jochen (gone - plz use gerrit), 2016-07-18 13:58:13]

lgtm

[Michael Achenbach, 2016-07-18 14:05:54]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:06:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 14:12:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-18 14:12:59]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Michael Achenbach, 2016-07-18 14:16:54]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org
==========

[Michael Achenbach, 2016-07-18 14:16:54]

machenbach@chromium.org changed reviewers:
+ alokp@chromium.org, brettw@chromium.org

[Michael Achenbach, 2016-07-18 14:17:51]

TBR for owners review:alokp@chromium.org, brettw@chromium.org
for files:
chromecast/BUILD.gn
net/BUILD.gn

[brettw, 2016-07-18 17:56:24]

lgtm

[Michael Achenbach, 2016-07-18 19:35:06]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-18 19:35:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 19:42:23]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org
==========

[commit-bot: I haz the power, 2016-07-18 19:42:24]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-18 19:42:55]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-07-18 19:44:27]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}
==========

[commit-bot: I haz the power, 2016-07-18 19:44:28]

Patchset 7 (id:??) landed as
https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}

[grt (UTC plus 2), 2016-07-18 19:57:32]

A revert of this CL (patchset #7 id:120001) has been created in
https://codereview.chromium.org/2160663003/ by grt@chromium.org.

The reason for reverting is: Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1.

[Michael Achenbach, 2016-07-20 09:14:35]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}
==========

[Michael Achenbach, 2016-07-20 09:15:18]

https://codereview.chromium.org/2169443002/ prepares to reland this. Needs to
roll into chromium and stick there first.

[Michael Achenbach, 2016-07-22 08:04:42]

Relanding this after https://codereview.chromium.org/2058033002/ has rolled now.

[Michael Achenbach, 2016-07-22 08:04:58]

The CQ bit was checked by machenbach@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-22 08:05:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:00:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:00:34]

Dry run: This issue passed the CQ dry run.

[Michael Achenbach, 2016-07-22 09:02:01]

The CQ bit was checked by machenbach@chromium.org

[commit-bot: I haz the power, 2016-07-22 09:02:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-22 09:05:42]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}
==========

[commit-bot: I haz the power, 2016-07-22 09:05:43]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-07-22 09:07:12]

Description was changed from

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Cr-Commit-Position: refs/heads/master@{#406067}
==========

to

==========
gn: Remove unnecessary v8 defaults

Remove chromium defaults for v8_optimized_debug and
v8_use_external_startup_data.

This is not needed after v8 provides these defaults:
https://codereview.chromium.org/2025803003/
https://codereview.chromium.org/2024833002/

It also interferes if somebody tries to override the gn args
with a different value.

BUG=chromium:616034
TBR=alokp@chromium.org, brettw@chromium.org

Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
Committed: https://crrev.com/d65ec5c9df401b4a60c6a57b2c9d5a539fe9191d
Cr-Original-Commit-Position: refs/heads/master@{#406067}
Cr-Commit-Position: refs/heads/master@{#407106}
==========

[commit-bot: I haz the power, 2016-07-22 09:07:14]

Patchset 7 (id:??) landed as
https://crrev.com/d65ec5c9df401b4a60c6a57b2c9d5a539fe9191d
Cr-Commit-Position: refs/heads/master@{#407106}