Revert of gn: Remove unnecessary v8 defaults

Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
>
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
>
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
>
> It also interferes if somebody tries to override the gn args
> with a different value.
>
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
>
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chromium.org,brettw@chromium.org,machenbach@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034
Committed: https://crrev.com/3c8546cbb39fecf4fcb0d0d29c9bca787ea1a7ac
Cr-Commit-Position: refs/heads/master@{#406072}

[grt (UTC plus 2), 2016-07-18 19:57:32]

The CQ bit was checked by grt@chromium.org

[grt (UTC plus 2), 2016-07-18 19:57:33]

Created Revert of gn: Remove unnecessary v8 defaults

[commit-bot: I haz the power, 2016-07-18 19:58:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-18 19:59:35]

Description was changed from

==========
Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of
https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
> 
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
> 
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
> 
> It also interferes if somebody tries to override the gn args
> with a different value.
> 
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
> 
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034
==========

to

==========
Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of
https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
> 
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
> 
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
> 
> It also interferes if somebody tries to override the gn args
> with a different value.
> 
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
> 
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034
==========

[commit-bot: I haz the power, 2016-07-18 19:59:37]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-07-18 20:02:38]

Description was changed from

==========
Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of
https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
> 
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
> 
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
> 
> It also interferes if somebody tries to override the gn args
> with a different value.
> 
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
> 
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034
==========

to

==========
Revert of gn: Remove unnecessary v8 defaults (patchset #7 id:120001 of
https://codereview.chromium.org/2058033002/ )

Reason for revert:
Seems to have broken Google Chrome Mac builder:
/b/c/b/Google_Chrome_Mac/src/buildtools/mac/gn gen //out/Release --check
  -> returned 1
ERROR at //chrome/BUILD.gn:514:7: Replacing nonempty list.
      remove_configs = [ "//build/config/mac:strip_all" ]
      ^-------------
This overwrites a previously-defined nonempty list (length 2).
See //v8/gni/v8.gni:55:3: for previous definition
  remove_configs += [ "//build/config/compiler:default_optimization" ]
  ^------------------------------------------------------------------
with another one (length 1). Did you mean "+=" to append instead? If you
really want to do this, do
  remove_configs = []
before reassigning.
See //BUILD.gn:202:7: which caused the file to be included.
      "//chrome",
      ^---------
GN gen failed: 1

Original issue's description:
> gn: Remove unnecessary v8 defaults
>
> Remove chromium defaults for v8_optimized_debug and
> v8_use_external_startup_data.
>
> This is not needed after v8 provides these defaults:
> https://codereview.chromium.org/2025803003/
> https://codereview.chromium.org/2024833002/
>
> It also interferes if somebody tries to override the gn args
> with a different value.
>
> BUG=chromium:616034
> TBR=alokp@chromium.org, brettw@chromium.org
>
> Committed: https://crrev.com/0fffeb2adaa3c284b760922c1aecce1516b998ce
> Cr-Commit-Position: refs/heads/master@{#406067}

TBR=jochen@chromium.org,dpranke@chromium.org,vogelheim@chromium.org,alokp@chr...
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=chromium:616034

Committed: https://crrev.com/3c8546cbb39fecf4fcb0d0d29c9bca787ea1a7ac
Cr-Commit-Position: refs/heads/master@{#406072}
==========

[commit-bot: I haz the power, 2016-07-18 20:02:39]

Patchset 1 (id:??) landed as
https://crrev.com/3c8546cbb39fecf4fcb0d0d29c9bca787ea1a7ac
Cr-Commit-Position: refs/heads/master@{#406072}

[Dirk Pranke, 2016-07-18 21:33:19]

lgtm

[Michael Achenbach, 2016-07-20 08:20:49]

lgtm - thanks for reverting. Did you see any other breakages?

[grt (UTC plus 2), 2016-07-20 09:25:09]

On 2016/07/20 08:20:49, Michael Achenbach (slow) wrote:
> lgtm - thanks for reverting. Did you see any other breakages?

I think some other Google Chrome bots failed with a similar/the same error.