build_overrides/v8.gni - Issue 2058033002: gn: Remove unnecessary v8 defaults

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build_overrides/v8.gni

Issue 2058033002: gn: Remove unnecessary v8 defaults (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixes Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build_overrides/v8.gni

diff --git a/build_overrides/v8.gni b/build_overrides/v8.gni

index af9d9cc68275662e90eb6e183d409ec32c0dc82b..668c0c70938d1fef9749b5df3e66da8d9c32543d 100644

--- a/build_overrides/v8.gni

+++ b/build_overrides/v8.gni

@@ -9,11 +9,6 @@ if (is_android) {

# TODO(sky): nuke this. Temporary while sorting out http://crbug.com/465456.

enable_correct_v8_arch = false

-v8_use_external_startup_data = !is_ios

-# Turns on compiler optimizations in V8 in Debug build.

-v8_optimized_debug = true

# V8 extras

# Adding V8 extras files requires API owners review

# Be sure to synchronize with build/common.gypi

« no previous file with comments | « BUILD.gn ('k') | chrome/BUILD.gn » ('j') | no next file with comments »