Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2025803003:
[gn] Turn on external_startup_data by default except on ios (Closed)
|
Created:
4 years, 6 months ago by Michael Achenbach Modified:
4 years, 6 months ago CC:
sdefresne, v8-reviews_googlegroups.com Base URL:
https://chromium.googlesource.com/v8/v8.git@master Target Ref:
refs/pending/heads/master Project:
v8 Visibility:
Public. |
Description[gn] Turn on external_startup_data by default except on ios
This sets the default for the feature, as chromium expects
it: It is turned on for all platforms except ios.
Chromium's build_override can be removed after this.
This will also allow to override the value as a gn arg.
BUG=chromium:474921, chromium:616034
NOTRY=true
Committed: https://crrev.com/c0774148d4f05eb8cf0267302ceecc7815346d18
Cr-Commit-Position: refs/heads/master@{#36666}
Patch Set 1 #Messages
Total messages: 19 (9 generated)
Description was changed from ========== [gn] Set chromium default for v8_use_external_startup_data BUG= ========== to ========== [gn] Set chromium default for v8_use_external_startup_data BUG=chromium:474921 NOTRY=true ==========
machenbach@chromium.org changed reviewers: + jochen@chromium.org, vogelheim@chromium.org
PTAL
Description was changed from ========== [gn] Set chromium default for v8_use_external_startup_data BUG=chromium:474921 NOTRY=true ========== to ========== [gn] Set chromium default for v8_use_external_startup_data BUG=chromium:474921,chromium:616034 NOTRY=true ==========
lgtm But... why? I thought the ios build doesn't even use V8, so why would it matter which parameters we use?
On 2016/05/31 13:55:14, vogelheim wrote: > lgtm > > But... why? I thought the ios build doesn't even use V8, so why would it matter > which parameters we use? We are the ones exposing the feature, therefore we should define a meaningful default. IOS compiles chromium, which includes v8 with this feature.
dpranke@chromium.org changed reviewers: + dpranke@chromium.org
Can you change the subject and/or description to more accurately describe what you're doing (changing the definition to be !is_ios)?
Description was changed from ========== [gn] Set chromium default for v8_use_external_startup_data BUG=chromium:474921,chromium:616034 NOTRY=true ========== to ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, chromium expects. It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true ==========
Description was changed from ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, chromium expects. It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true ========== to ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, as chromium expects it: It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true ==========
Updated the description.
lgtm
lgtm, thanks.
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2025803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/2025803003/1
Message was sent while issue was closed.
Description was changed from ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, as chromium expects it: It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true ========== to ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, as chromium expects it: It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, as chromium expects it: It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true ========== to ========== [gn] Turn on external_startup_data by default except on ios This sets the default for the feature, as chromium expects it: It is turned on for all platforms except ios. Chromium's build_override can be removed after this. This will also allow to override the value as a gn arg. BUG=chromium:474921,chromium:616034 NOTRY=true Committed: https://crrev.com/c0774148d4f05eb8cf0267302ceecc7815346d18 Cr-Commit-Position: refs/heads/master@{#36666} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/c0774148d4f05eb8cf0267302ceecc7815346d18 Cr-Commit-Position: refs/heads/master@{#36666} |
