MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.

MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e85dfff4e9e360d93be39fb73bb2197e44a67f17
Cr-Commit-Position: refs/heads/master@{#399617}

[dpapad, 2016-06-09 17:37:25]

Description was changed from

==========
MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.

BUG=617830
==========

to

==========
MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-09 21:29:23]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-06-09 21:29:27]

Patchset #1 (id:20001) has been deleted

[dpapad, 2016-06-09 21:29:31]

Patchset #1 (id:40001) has been deleted

[dpapad, 2016-06-09 21:42:19]

dpapad@chromium.org changed reviewers:
+ dbeam@chromium.org, stevenjb@chromium.org

[dpapad, 2016-06-09 21:42:19]

This CL adds the new C++ handler (and corresponding JS browser proxy), that will
be used from all MD Settings UI surfaces that need to trigger a
restart/relaunch/powerwash.

Hooking up UI to the new handler (and cleaning up existing handlers), is split
to separate CLs,

system_page: https://codereview.chromium.org/2055923002
languages_page: https://codereview.chromium.org/2052793004
reset_page: https://codereview.chromium.org/2052003002
about_page: WIP...

@stevenjb: My immediate goal is to unify such codepaths within MD Settings for
now, and not across the entire WebUI (for example old Options). Therefore I
chose not to split the "powerwash" functionality to a separate class that the
new MD Settings C++ handler would call into.

The current refactoring allows for pulling that functionality one level up, at
chrome/browser/ui/webui/, if needed, in a follow up CL, such that "factory
reset"
codepaths can be unified across different WebUI pages.

[Dan Beam, 2016-06-09 23:09:53]

who's reviewing what?

[dpapad, 2016-06-09 23:38:19]

On 2016/06/09 at 23:09:53, dbeam wrote:
> who's reviewing what?

@dbeam: Please review everything.
@stevenjb: Wanted to make sure that your concern expressed in the
chrome-settings thread is addressed.

[stevenjb, 2016-06-09 23:47:53]

stevenjb@chromium.org changed reviewers:
+ michaelpg@chromium.org

[stevenjb, 2016-06-09 23:47:54]

This looks great, thanks for wrapping this. Once this is in we should see if
there are other places in chrome (e.g. chromeos login) where we be able to use
this instead of a custom handler.

I only scanned through this quickly. michaelpg@, could you take a closer look at
the power / reset chromeos code?

[dpapad, 2016-06-13 18:05:21]

On 2016/06/09 at 23:47:54, stevenjb wrote:
> This looks great, thanks for wrapping this. Once this is in we should see if
there are other places in chrome (e.g. chromeos login) where we be able to use
this instead of a custom handler.
> 
> I only scanned through this quickly. michaelpg@, could you take a closer look
at the power / reset chromeos code?

@michaelpg, @dbeam: Friendly ping.

[michaelpg, 2016-06-13 20:56:11]

On 2016/06/09 23:47:54, stevenjb wrote:
> This looks great, thanks for wrapping this. Once this is in we should see if
> there are other places in chrome (e.g. chromeos login) where we be able to use
> this instead of a custom handler.
> 
> I only scanned through this quickly. michaelpg@, could you take a closer look
at
> the power / reset chromeos code?

lgtm

[Dan Beam, 2016-06-13 21:09:13]

where is the testbrowserproxy used?  did you forget to `git add` a
_browsertest.js file?

https://codereview.chromium.org/2057593003/diff/100001/chrome/browser/ui/webu...
File chrome/browser/ui/webui/settings/md_settings_ui.cc (right):

https://codereview.chromium.org/2057593003/diff/100001/chrome/browser/ui/webu...
chrome/browser/ui/webui/settings/md_settings_ui.cc:67:
AddSettingsPageUIHandler(new BrowserLifetimeHandler());
nit: why are you adding this here?  so far it seems as if these are in
alphabetical order

[Dan Beam, 2016-06-13 21:11:14]

never mind, looked at dependent patchsets

lgtm

[dpapad, 2016-06-13 21:16:53]

On 2016/06/13 at 21:11:14, dbeam wrote:
> never mind, looked at dependent patchsets
> 
> lgtm

Thanks!

[dpapad, 2016-06-13 21:18:25]

The CQ bit was checked by dpapad@chromium.org

[commit-bot: I haz the power, 2016-06-13 21:19:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2057593003/100001

[commit-bot: I haz the power, 2016-06-14 00:31:07]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-14 00:34:29]

Description was changed from

==========
MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Add dedicated C++ handler for restart/relaunch/powerwash.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/e85dfff4e9e360d93be39fb73bb2197e44a67f17
Cr-Commit-Position: refs/heads/master@{#399617}
==========

[commit-bot: I haz the power, 2016-06-14 00:34:34]

Patchset 3 (id:??) landed as
https://crrev.com/e85dfff4e9e360d93be39fb73bb2197e44a67f17
Cr-Commit-Position: refs/heads/master@{#399617}