Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2055923002: MD Settings: Hook up system_page to new LifetimeBrowserProxy. (Closed)

Created:
4 years, 6 months ago by dpapad
Modified:
4 years, 6 months ago
Reviewers:
Dan Beam
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lifetime_handler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Hook up system_page to new LifetimeBrowserProxy. BUG=617830 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/8a84aa50f0c16bc9c98c4eaca37d5902b927ebf8 Cr-Commit-Position: refs/heads/master@{#399749}

Patch Set 1 #

Patch Set 2 : Nit #

Patch Set 3 : Fix closure compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -31 lines) Patch
M chrome/browser/resources/settings/system_page/compiled_resources2.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/system_page/system_page.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/settings/system_page/system_page_browser_proxy.js View 2 chunks +0 lines, -8 lines 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/system_handler.cc View 3 chunks +0 lines, -8 lines 0 comments Download
M chrome/test/data/webui/settings/cr_settings_browsertest.js View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/test/data/webui/settings/system_page_tests.js View 1 3 chunks +11 lines, -11 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (7 generated)
dpapad
4 years, 6 months ago (2016-06-13 21:59:22 UTC) #3
Dan Beam
lgtm though I reserve the right to hate on globals in tests :D
4 years, 6 months ago (2016-06-14 00:10:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055923002/20001
4 years, 6 months ago (2016-06-14 01:33:06 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/529)
4 years, 6 months ago (2016-06-14 02:14:03 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055923002/40001
4 years, 6 months ago (2016-06-14 17:10:22 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-14 18:18:19 UTC) #12
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 18:19:46 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8a84aa50f0c16bc9c98c4eaca37d5902b927ebf8
Cr-Commit-Position: refs/heads/master@{#399749}

Powered by Google App Engine
This is Rietveld 408576698