MD Settings: Hook up reset_page to new LifetimeBrowserProxy.

MD Settings: Hook up reset_page to new LifetimeBrowserProxy.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ea89257a210249beb56af2c68b56847dfb798119
Cr-Commit-Position: refs/heads/master@{#399643}

[dpapad, 2016-06-09 20:51:48]

Description was changed from

==========
MD Settings: Hook up reset_page to new LifetimeBrowserProxy.

BUG=617830
==========

to

==========
MD Settings: Hook up reset_page to new LifetimeBrowserProxy.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

[dpapad, 2016-06-10 21:26:59]

Patchset #1 (id:1) has been deleted

[dpapad, 2016-06-10 21:27:03]

Patchset #1 (id:20001) has been deleted

[dpapad, 2016-06-10 21:27:07]

Patchset #1 (id:40001) has been deleted

[dpapad, 2016-06-10 22:25:38]

dpapad@chromium.org changed reviewers:
+ tommycli@chromium.org

[dpapad, 2016-06-10 22:25:39]

FYI, this CL depends on https://codereview.chromium.org/2057593003 (which is
still under review).

[tommycli, 2016-06-13 22:48:17]

lgtm to me sans below nits:

https://codereview.chromium.org/2052003002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/reset_page_test.js (right):

https://codereview.chromium.org/2052003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/reset_page_test.js:123: var lifetimeBrowserProxy
= null;
Should this only be created on cr.isChromeOS only? I am not sure myself, just a
suggestion.

https://codereview.chromium.org/2052003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/reset_page_test.js:266: //registerBannerTests();
nit: is this a leftover?

[dpapad, 2016-06-13 23:02:27]

Thanks!

https://codereview.chromium.org/2052003002/diff/80001/chrome/test/data/webui/...
File chrome/test/data/webui/settings/reset_page_test.js (right):

https://codereview.chromium.org/2052003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/reset_page_test.js:123: var lifetimeBrowserProxy
= null;
On 2016/06/13 at 22:48:16, tommycli wrote:
> Should this only be created on cr.isChromeOS only? I am not sure myself, just
a suggestion.

I thought about this (and also tried it). IMO it looks odd to put the variable
declaration inside an if statement (and can be confusing to future readers who
are not familiar with JS Hoisting, http://www.w3schools.com/js/js_hoisting.asp).
So I think initializing to null, and never assigning a non-null value on
non-ChromeOS is less odd.

https://codereview.chromium.org/2052003002/diff/80001/chrome/test/data/webui/...
chrome/test/data/webui/settings/reset_page_test.js:266: //registerBannerTests();
On 2016/06/13 at 22:48:17, tommycli wrote:
> nit: is this a leftover?

Oops, yes this should not be commented out, reverted.

[dpapad, 2016-06-14 01:12:20]

The CQ bit was checked by dpapad@chromium.org

[dpapad, 2016-06-14 01:12:20]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org
Link to the patchset: https://codereview.chromium.org/2052003002/#ps100001
(title: "Address comment.")

[commit-bot: I haz the power, 2016-06-14 01:12:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052003002/100001

[commit-bot: I haz the power, 2016-06-14 02:29:57]

Committed patchset #3 (id:100001)

[commit-bot: I haz the power, 2016-06-14 02:30:03]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-14 03:40:18]

Description was changed from

==========
MD Settings: Hook up reset_page to new LifetimeBrowserProxy.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation
==========

to

==========
MD Settings: Hook up reset_page to new LifetimeBrowserProxy.

BUG=617830
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/ea89257a210249beb56af2c68b56847dfb798119
Cr-Commit-Position: refs/heads/master@{#399643}
==========

[commit-bot: I haz the power, 2016-06-14 03:40:19]

Patchset 3 (id:??) landed as
https://crrev.com/ea89257a210249beb56af2c68b56847dfb798119
Cr-Commit-Position: refs/heads/master@{#399643}