Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issue 2052793004: MD Settings: Hook up languages_page to new LifetimeBrowserProxy. (Closed)

Created:
4 years, 6 months ago by dpapad
Modified:
4 years, 6 months ago
Reviewers:
michaelpg
CC:
arv+watch_chromium.org, chromium-reviews, dbeam+watch-settings_chromium.org, michaelpg+watch-md-settings_chromium.org, michaelpg+watch-md-ui_chromium.org, stevenjb+watch-md-settings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@lifetime_handler
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Settings: Hook up languages_page to new LifetimeBrowserProxy. BUG=617830 CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/d9fa0f5bc55ab90095a803c02450b1c19195b610 Cr-Commit-Position: refs/heads/master@{#399740}

Patch Set 1 #

Patch Set 2 : Fix closure compilation. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -17 lines) Patch
M chrome/browser/resources/settings/languages_page/compiled_resources2.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/language_detail_page.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/settings/languages_page/language_detail_page.js View 1 chunk +6 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/settings/languages_handler.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/settings/languages_handler.cc View 3 chunks +0 lines, -13 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 17 (7 generated)
dpapad
FYI, this CL depends on https://codereview.chromium.org/2057593003 (which is still under review).
4 years, 6 months ago (2016-06-10 23:05:37 UTC) #3
michaelpg
lgtm!
4 years, 6 months ago (2016-06-13 16:01:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052793004/1
4 years, 6 months ago (2016-06-14 01:12:51 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: closure_compilation on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/closure_compilation/builds/530)
4 years, 6 months ago (2016-06-14 02:09:33 UTC) #8
Dan Beam
you need to add some dependencies to a compiled_resources2.gyp
4 years, 6 months ago (2016-06-14 15:32:55 UTC) #9
dpapad
On 2016/06/14 at 15:32:55, dbeam wrote: > you need to add some dependencies to a ...
4 years, 6 months ago (2016-06-14 17:12:39 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052793004/20001
4 years, 6 months ago (2016-06-14 17:13:12 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-14 17:50:36 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-14 17:50:41 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-14 17:52:11 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d9fa0f5bc55ab90095a803c02450b1c19195b610
Cr-Commit-Position: refs/heads/master@{#399740}

Powered by Google App Engine
This is Rietveld 408576698