Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Issue 2056443002: Manual refactor to enum-based WaitableEvent for remaining mac/ios files (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj, fdoray
CC:
chromium-reviews, cbentzel+watch_chromium.org, feature-media-reviews_chromium.org, Lei Zhang, jam, tommycli, darin-cc_chromium.org, sdefresne+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_1_explicit_bools
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Manual refactor to enum-based WaitableEvent for remaining mac/ios files BUG=612843 NO_DEPENDENCY_CHECKS=true R=fdoray@chromium.org TBR=danakj@chromium.org (Francois please fact check me, I'm TBRing dana for otherwise mechanical change) Committed: https://crrev.com/5600d5b816bb658eeeae87a53158a500d985f1da Cr-Commit-Position: refs/heads/master@{#398689}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -12 lines) Patch
M chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm View 4 chunks +8 lines, -4 lines 0 comments Download
M components/cronet/ios/cronet_environment.cc View 1 chunk +3 lines, -1 line 0 comments Download
M components/cronet/ios/test/cronet_bidirectional_stream_test.mm View 1 chunk +2 lines, -1 line 0 comments Download
M components/cronet/ios/test/quic_test_server.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/browser/mach_broker_mac_unittest.cc View 1 chunk +3 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.cc View 1 chunk +3 lines, -1 line 0 comments Download
M media/audio/mac/audio_auhal_mac_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/accelerated_widget_mac/window_resize_helper_mac.cc View 1 chunk +2 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
gab
Francois please fact check me since this was done manually (and CQ if lg) TBR ...
4 years, 6 months ago (2016-06-08 19:04:54 UTC) #2
gab
On 2016/06/08 19:04:54, gab wrote: > Francois please fact check me since this was done ...
4 years, 6 months ago (2016-06-08 19:43:08 UTC) #5
fdoray
lgtm
4 years, 6 months ago (2016-06-08 19:54:39 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056443002/1
4 years, 6 months ago (2016-06-08 20:18:27 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 21:44:57 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5600d5b816bb658eeeae87a53158a500d985f1da Cr-Commit-Position: refs/heads/master@{#398689}
4 years, 6 months ago (2016-06-08 21:47:40 UTC) #12
danakj
4 years, 6 months ago (2016-06-09 20:05:35 UTC) #13
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698