Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm

Issue 2056443002: Manual refactor to enum-based WaitableEvent for remaining mac/ios files (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@d_1_explicit_bools
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/ios/cronet_environment.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
diff --git a/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm b/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
index c53aa2dcd2b7bef9b073582c8e569abcf44befb7..f3f9b99be14f06fd22a7d167ffa47dc23549208a 100644
--- a/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
+++ b/chrome/browser/media_galleries/mac/mtp_device_delegate_impl_mac_unittest.mm
@@ -234,7 +234,8 @@ class MTPDeviceDelegateImplMacTest : public testing::Test {
base::File::Error GetFileInfo(const base::FilePath& path,
base::File::Info* info) {
- base::WaitableEvent wait(true, false);
+ base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
delegate_->GetFileInfo(
path,
base::Bind(&MTPDeviceDelegateImplMacTest::OnFileInfo,
@@ -251,7 +252,8 @@ class MTPDeviceDelegateImplMacTest : public testing::Test {
}
base::File::Error ReadDir(const base::FilePath& path) {
- base::WaitableEvent wait(true, false);
+ base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
delegate_->ReadDirectory(
path,
base::Bind(&MTPDeviceDelegateImplMacTest::OnReadDir,
@@ -269,7 +271,8 @@ class MTPDeviceDelegateImplMacTest : public testing::Test {
base::File::Error DownloadFile(
const base::FilePath& path,
const base::FilePath& local_path) {
- base::WaitableEvent wait(true, false);
+ base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
delegate_->CreateSnapshotFile(
path, local_path,
base::Bind(&MTPDeviceDelegateImplMacTest::OnDownload,
@@ -336,7 +339,8 @@ TEST_F(MTPDeviceDelegateImplMacTest, TestOverlappedReadDir) {
info1.creation_time = time1;
delegate_->ItemAdded("name1", info1);
- base::WaitableEvent wait(true, false);
+ base::WaitableEvent wait(base::WaitableEvent::ResetPolicy::MANUAL,
+ base::WaitableEvent::InitialState::NOT_SIGNALED);
delegate_->ReadDirectory(
base::FilePath(kDevicePath),
« no previous file with comments | « no previous file | components/cronet/ios/cronet_environment.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698