Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 2052573002: Migrate to enum-based constructor for callsites using non-inlined bools. (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
Fady Samuel, enne (OOO)
CC:
chromium-reviews, rjkroege, piman+watch_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@d_0_windows_manual
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WaitableEvent to enum-based constructor for callsites using non-inlined bools. As expected: clang-tidy couldn't auto-refactor those non-inlined bools BUG=612843 CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel NO_DEPENDENCY_CHECKS=true TBR=Have owners approval, skipping NO_DEPENDENCY_CHECKS bug for presubmit (http://crbug.com/616912) Committed: https://crrev.com/cca5311b816c24b07adcdfda0b03297118feee2c Cr-Commit-Position: refs/heads/master@{#398652}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -11 lines) Patch
M cc/layers/texture_layer_unittest.cc View 2 chunks +11 lines, -8 lines 0 comments Download
M components/mus/gpu/gpu_service_mus.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 16 (10 generated)
gab
Tiny mechanical change: @fsamuel for mus/gpu @enne for cc/layers Thanks, Gab
4 years, 6 months ago (2016-06-08 18:46:12 UTC) #5
Fady Samuel
mus lgtm
4 years, 6 months ago (2016-06-08 18:47:46 UTC) #6
enne (OOO)
lgtm
4 years, 6 months ago (2016-06-08 19:01:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2052573002/1
4 years, 6 months ago (2016-06-08 19:03:33 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 20:13:43 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-08 20:15:52 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/cca5311b816c24b07adcdfda0b03297118feee2c
Cr-Commit-Position: refs/heads/master@{#398652}

Powered by Google App Engine
This is Rietveld 408576698