Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/7a5d04b5299133bf31df423e0eb125fbb2998d65
Cr-Commit-Position: refs/heads/master@{#398693}

[gab, 2016-06-08 19:44:31]

Description was changed from

==========
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
==========

to

==========
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
NO_DEPENDENCY_CHECKS=true
==========

[gab, 2016-06-08 20:02:25]

Patchset #2 (id:20001) has been deleted

[gab, 2016-06-08 20:02:31]

Patchset #1 (id:1) has been deleted

[gab, 2016-06-08 20:08:33]

gab@chromium.org changed reviewers:
+ thakis@chromium.org

[gab, 2016-06-08 20:08:34]

Nico PTAL as owner of third_party\WebKit\Source\platform\. It's interesting to
realize with this change that WebKit happens to have made the same design
decision for this that we just made in base (nested enum classes in their
WaitableEvent.h -- even named the same as ours :-O)

But they have default values for the parameters, i.e. (ResetPolicy::Auto,
InitialState::NonSignaled).

That could be worthwhile for us too since the vast majority of callers use
InitialState::NOT_SIGNALED (i.e. very rarely need two params) and more than half
of those callers use ResetPolicy::AUTOMATIC (and could thus use 0 params).

I opened the discussion for this @ https://crbug.com/612843#c49

Thanks,
Gab

[Nico, 2016-06-08 20:20:41]

lgtm

(fwiw i like switch()es over enums, since then the compiler can tell me if i'm
missing a case in my switch if someone adds more enum values later)

[gab, 2016-06-08 20:36:41]

On 2016/06/08 20:20:41, Nico wrote:
> lgtm
> 
> (fwiw i like switch()es over enums, since then the compiler can tell me if i'm
> missing a case in my switch if someone adds more enum values later)

Agreed in general but here it'd be *very* surprising IMO for someone to add an
enum value and not double check the very constructor that uses them.

[gab, 2016-06-08 20:36:48]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-06-08 20:37:27]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052593002/40001

[commit-bot: I haz the power, 2016-06-08 20:46:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-08 20:46:23]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[gab, 2016-06-08 21:48:54]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2016-06-08 21:49:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052593002/40001

[commit-bot: I haz the power, 2016-06-08 21:54:29]

Description was changed from

==========
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
NO_DEPENDENCY_CHECKS=true
==========

[commit-bot: I haz the power, 2016-06-08 21:54:31]

Committed patchset #1 (id:40001)

[commit-bot: I haz the power, 2016-06-08 21:56:15]

Description was changed from

==========
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
NO_DEPENDENCY_CHECKS=true
==========

to

==========
Adapt WebKit's WaitableEvent to base's new enum-based WaitableEvent

BUG=612843
NO_DEPENDENCY_CHECKS=true

Committed: https://crrev.com/7a5d04b5299133bf31df423e0eb125fbb2998d65
Cr-Commit-Position: refs/heads/master@{#398693}
==========

[commit-bot: I haz the power, 2016-06-08 21:56:16]

Patchset 1 (id:??) landed as
https://crrev.com/7a5d04b5299133bf31df423e0eb125fbb2998d65
Cr-Commit-Position: refs/heads/master@{#398693}