[Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

[Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API.

This change cascaded through several callers but eventually
resolved with only addition to the block layout API:
LayoutViewItem::viewportSizeForViewportUnits

A few additional changes were required because LayoutViewItem has
explicit constructors, so places where we were passing nullptr
need to be wrapped in LayoutViewItem(nullptr) instead.

There are no functional changes.

BUG=499321
Committed: https://crrev.com/10dd9ce6cfeb62dfae62328130392186bffb9d6c
Cr-Commit-Position: refs/heads/master@{#402962}

[pilgrim_google, 2016-06-10 14:21:03]

pilgrim@chromium.org changed reviewers:
+ eae@chromium.org, jsbell@chromium.org

[rune, 2016-06-10 16:38:48]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2016-06-10 16:38:49]

lgtm

https://codereview.chromium.org/2056303002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/CSSToLengthConversionData.h (right):

https://codereview.chromium.org/2056303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSToLengthConversionData.h:74: explicit
ViewportSize(const LayoutViewItem);
Why not const ref? Is this as efficient nowadays?

https://codereview.chromium.org/2056303002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/CSSToLengthConversionData.h:84:
CSSToLengthConversionData(const ComputedStyle* currStyle, const ComputedStyle*
rootStyle, const LayoutViewItem, float zoom);
ditto (const ref)

[eae, 2016-06-21 09:20:58]

LGTM but please address runes comments before landing.

[pilgrim_google, 2016-06-29 19:05:20]

The CQ bit was checked by pilgrim@chromium.org

[pilgrim_google, 2016-06-29 19:05:21]

The patchset sent to the CQ was uploaded after l-g-t-m from eae@chromium.org,
rune@opera.com
Link to the patchset: https://codereview.chromium.org/2056303002/#ps20001
(title: "changed both declarations to const ref as per rune")

[commit-bot: I haz the power, 2016-06-29 19:07:01]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 20:19:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-29 20:19:08]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pilgrim_google, 2016-06-29 20:30:34]

The CQ bit was checked by pilgrim@chromium.org

[commit-bot: I haz the power, 2016-06-29 20:31:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-06-29 22:35:53]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-29 22:36:28]

CQ bit was unchecked.

[commit-bot: I haz the power, 2016-06-29 22:37:33]

Description was changed from

==========
[Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API.

This change cascaded through several callers but eventually
resolved with only addition to the block layout API:
LayoutViewItem::viewportSizeForViewportUnits

A few additional changes were required because LayoutViewItem has
explicit constructors, so places where we were passing nullptr
need to be wrapped in LayoutViewItem(nullptr) instead.

There are no functional changes.

BUG=499321
==========

to

==========
[Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

Document::layoutView() is deprecated and being removed soon. The
replacement is Document::layoutViewItem(), which routes methods
through the new block layout API.

This change cascaded through several callers but eventually
resolved with only addition to the block layout API:
LayoutViewItem::viewportSizeForViewportUnits

A few additional changes were required because LayoutViewItem has
explicit constructors, so places where we were passing nullptr
need to be wrapped in LayoutViewItem(nullptr) instead.

There are no functional changes.

BUG=499321

Committed: https://crrev.com/10dd9ce6cfeb62dfae62328130392186bffb9d6c
Cr-Commit-Position: refs/heads/master@{#402962}
==========

[commit-bot: I haz the power, 2016-06-29 22:37:34]

Patchset 2 (id:??) landed as
https://crrev.com/10dd9ce6cfeb62dfae62328130392186bffb9d6c
Cr-Commit-Position: refs/heads/master@{#402962}