third_party/WebKit/Source/core/css/CSSMatrix.cpp - Issue 2056303002: [Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSMatrix.cpp

Issue 2056303002: [Layout API] Use Document::layoutViewItem() in ViewportStyleResolver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed both declarations to const ref as per rune Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/CSSGradientValue.cpp ('k') | third_party/WebKit/Source/core/css/CSSToLengthConversionData.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/CSSMatrix.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSMatrix.cpp b/third_party/WebKit/Source/core/css/CSSMatrix.cpp

index e1011aed50e631924b2e7b6eb8f59c7349c53183..62801770bf39e5a01e2ab5fd65197f260fe4cbae 100644

--- a/third_party/WebKit/Source/core/css/CSSMatrix.cpp

+++ b/third_party/WebKit/Source/core/css/CSSMatrix.cpp

@@ -34,6 +34,7 @@

#include "core/css/resolver/TransformBuilder.h"

#include "core/dom/ExceptionCode.h"

#include "core/frame/UseCounter.h"

+#include "core/layout/api/LayoutViewItem.h"

#include "core/style/ComputedStyle.h"

#include "core/style/StyleInheritedData.h"

#include "wtf/MathExtras.h"

@@ -76,7 +77,7 @@ void CSSMatrix::setMatrixValue(const String& string, ExceptionState& exceptionSt

DEFINE_STATIC_REF(ComputedStyle, initialStyle, createInitialStyle());

TransformOperations operations;

- TransformBuilder::createTransformOperations(*value, CSSToLengthConversionData(initialStyle, initialStyle, nullptr, 1.0f), operations);

+ TransformBuilder::createTransformOperations(*value, CSSToLengthConversionData(initialStyle, initialStyle, LayoutViewItem(nullptr), 1.0f), operations);

// Convert transform operations to a TransformationMatrix. This can fail

// if a param has a percentage ('%')