third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp - Issue 2056303002: [Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp

Issue 2056303002: [Layout API] Use Document::layoutViewItem() in ViewportStyleResolver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed both declarations to const ref as per rune Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp

diff --git a/third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp b/third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp

index 9e4cd3b8292375f65f87d02405348112b2ba5791..7744dba482762aa3643056e8f538a6a66be4883f 100644

--- a/third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp

+++ b/third_party/WebKit/Source/core/css/CSSCalculationValueTest.cpp

@@ -33,6 +33,7 @@

#include "core/css/CSSPrimitiveValue.h"

#include "core/css/CSSToLengthConversionData.h"

#include "core/css/StylePropertySet.h"

+#include "core/layout/api/LayoutViewItem.h"

#include "core/style/ComputedStyle.h"

#include "core/style/StyleInheritedData.h"

#include "testing/gtest/include/gtest/gtest.h"

@@ -78,7 +79,7 @@ TEST(CSSCalculationValue, AccumulatePixelsAndPercent)

{

RefPtr<ComputedStyle> style = ComputedStyle::create();

style->setEffectiveZoom(5);

- CSSToLengthConversionData conversionData(style.get(), style.get(), nullptr, style->effectiveZoom());

+ CSSToLengthConversionData conversionData(style.get(), style.get(), LayoutViewItem(nullptr), style->effectiveZoom());

testAccumulatePixelsAndPercent(conversionData,

CSSCalcValue::createExpressionNode(CSSPrimitiveValue::create(10, CSSPrimitiveValue::UnitType::Pixels), true),

« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSGradientValue.cpp » ('j') | no next file with comments »