third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp - Issue 2056303002: [Layout API] Use Document::layoutViewItem() in ViewportStyleResolver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

Issue 2056303002: [Layout API] Use Document::layoutViewItem() in ViewportStyleResolver (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: changed both declarations to const ref as per rune Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/resolver/StyleResolverState.cpp ('k') | third_party/WebKit/Source/core/layout/api/LayoutViewItem.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp b/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

index 1e40fcd4343b4d4246ffeb2f9f95faae56b42af8..c33e1f6801b0ad1b69403e4100ee16f6d653d9b0 100644

--- a/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/ViewportStyleResolver.cpp

@@ -40,6 +40,7 @@

#include "core/dom/NodeComputedStyle.h"

#include "core/dom/ViewportDescription.h"

#include "core/frame/Settings.h"

+#include "core/layout/api/LayoutViewItem.h"

namespace blink {

@@ -211,7 +212,7 @@ Length ViewportStyleResolver::viewportLengthValue(CSSPropertyID id) const

documentStyle->setHasViewportUnits(false);

CSSToLengthConversionData::FontSizes fontSizes(documentStyle, documentStyle);

- CSSToLengthConversionData::ViewportSize viewportSize(m_document->layoutView());

+ CSSToLengthConversionData::ViewportSize viewportSize(m_document->layoutViewItem());

if (primitiveValue->getValueID() == CSSValueAuto)

return Length(Auto);