third_party/WebKit/Source/modules/payments/PaymentResponse.h - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.h

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentCompleter.h ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentResponse.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.h b/third_party/WebKit/Source/modules/payments/PaymentResponse.h

index 5d6abfb53f716c75c2aabc2d424c9bb77918fe21..75d608cf2abc220acce8c489db73ccf260068c27 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.h

@@ -33,7 +33,7 @@ public:

ScriptValue details(ScriptState*, ExceptionState&) const;

PaymentAddress* shippingAddress() const { return m_shippingAddress.get(); }

- ScriptPromise complete(ScriptState*, bool success);

+ ScriptPromise complete(ScriptState*, const String& result = "");

please use gerrit instead 2016/06/10 19:15:35 I have not worked with enums in Blink before. Is t

please use gerrit instead 2016/06/13 15:28:10 Nevermind, ignore this comment.

DECLARE_TRACE();