third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/payments/PaymentCompleter.h ('K') | « third_party/WebKit/Source/modules/payments/PaymentRequest.cpp ('k') | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

diff --git a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

index 1f0d20c65d93438c17c281f8d13176dc4457eed3..2df27e7381adecf5b9ecdc7e29f7bdaa570cf202 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

+++ b/third_party/WebKit/Source/modules/payments/PaymentRequestTest.cpp

@@ -398,9 +398,9 @@ TEST_F(PaymentRequestTest, CannotCallCompleteTwice)

EXPECT_FALSE(getExceptionState().hadException());

request->show(getScriptState());

static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());

- request->complete(getScriptState(), false);

+ request->complete(getScriptState(), Fail);

- request->complete(getScriptState(), true).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));

+ request->complete(getScriptState(), Success).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));

}

TEST_F(PaymentRequestTest, RejectShowPromiseOnError)

@@ -422,7 +422,7 @@ TEST_F(PaymentRequestTest, RejectCompletePromiseOnError)

request->show(getScriptState());

static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());

- request->complete(getScriptState(), true).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));

+ request->complete(getScriptState(), Success).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));

static_cast<mojom::blink::PaymentRequestClient*>(request)->OnError();

}

@@ -435,7 +435,7 @@ TEST_F(PaymentRequestTest, ResolvePromiseOnComplete)

request->show(getScriptState());

static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());

- request->complete(getScriptState(), true).then(MockFunction::expectCall(getScriptState()), MockFunction::expectNoCall(getScriptState()));

+ request->complete(getScriptState(), Success).then(MockFunction::expectCall(getScriptState()), MockFunction::expectNoCall(getScriptState()));

static_cast<mojom::blink::PaymentRequestClient*>(request)->OnComplete();

}

@@ -459,7 +459,7 @@ TEST_F(PaymentRequestTest, RejectCompletePromiseOnUpdateDetailsFailure)

request->show(getScriptState()).then(MockFunction::expectCall(getScriptState()), MockFunction::expectNoCall(getScriptState()));

static_cast<mojom::blink::PaymentRequestClient*>(request)->OnPaymentResponse(mojom::blink::PaymentResponse::New());

- request->complete(getScriptState(), true).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));

+ request->complete(getScriptState(), Success).then(MockFunction::expectNoCall(getScriptState()), MockFunction::expectCall(getScriptState()));

request->onUpdatePaymentDetailsFailure(ScriptValue::from(getScriptState(), "oops"));

}