PaymentRequest: complete() method should take PaymentComplete enum value.

third_party/WebKit/Source/modules/payments/PaymentResponse.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef PaymentResponse_h
 #define PaymentResponse_h
 
 #include "bindings/core/v8/ScriptPromise.h"
 #include "bindings/core/v8/ScriptValue.h"
 #include "bindings/core/v8/ScriptWrappable.h"
@@ skipping 15 matching lines @@
     WTF_MAKE_NONCOPYABLE(PaymentResponse);
 
 public:
     PaymentResponse(mojom::blink::PaymentResponsePtr, PaymentCompleter*);
     virtual ~PaymentResponse();
 
     const String& methodName() const { return m_methodName; }
     ScriptValue details(ScriptState*, ExceptionState&) const;
     PaymentAddress* shippingAddress() const { return m_shippingAddress.get(); }
 
-    ScriptPromise complete(ScriptState*, bool success);
+    ScriptPromise complete(ScriptState*, const String& result = "");

[please use gerrit instead, 2016/06/10 19:15:35]

I have not worked with enums in Blink before. Is this really how it works? Right
now you have IDL enum represented as strings in C++ that you convert into your
own enum values in C++: that seems suboptimal. I was hoping that IDL generator
could help us here.

[please use gerrit instead, 2016/06/13 15:28:10]

Nevermind, ignore this comment.

 
     DECLARE_TRACE();
 
 private:
     String m_methodName;
     String m_stringifiedDetails;
     Member<PaymentAddress> m_shippingAddress;
     Member<PaymentCompleter> m_paymentCompleter;
 };
 
 } // namespace blink
 
 #endif // PaymentResponse_h