third_party/WebKit/Source/modules/payments/PaymentCompleter.h - Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentCompleter.h

Issue 2054823002: PaymentRequest: complete() method should take PaymentComplete enum value. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/payments/ui/PaymentResultUIManager.java ('K') | « chrome/test/data/android/payments/no_shipping.js ('k') | third_party/WebKit/Source/modules/payments/PaymentRequest.h » ('j') | third_party/WebKit/Source/modules/payments/PaymentResponse.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/payments/PaymentCompleter.h

diff --git a/third_party/WebKit/Source/modules/payments/PaymentCompleter.h b/third_party/WebKit/Source/modules/payments/PaymentCompleter.h

index 284d2a16d9e36bd5fd29e549b4ec85daff423cc3..52b44019229f26facc5d78df87aaab954ad01023 100644

--- a/third_party/WebKit/Source/modules/payments/PaymentCompleter.h

+++ b/third_party/WebKit/Source/modules/payments/PaymentCompleter.h

@@ -11,11 +11,17 @@

namespace blink {

+enum PaymentComplete {

please use gerrit instead 2016/06/10 19:15:35 Doesn't PaymentResponse.idl generate the enum for

please use gerrit instead 2016/06/13 15:28:10 Nevermind, ignore this comment.

+ Success,

+ Fail,

+ Unknown

+};

class ScriptState;

class MODULES_EXPORT PaymentCompleter : public GarbageCollectedMixin {

public:

- virtual ScriptPromise complete(ScriptState*, bool success) = 0;

+ virtual ScriptPromise complete(ScriptState*, const PaymentComplete result) = 0;

protected:

virtual ~PaymentCompleter() {}