components/translate/core/browser/translate_manager_unittest.cc - Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/core/browser/translate_manager_unittest.cc

Issue 2053913002: Remove MessageLoop::current()->RunUntilIdle() in components. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/non_ui_data_type_controller_unittest.cc ('k') | components/web_resource/resource_request_allowed_notifier_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/core/browser/translate_manager_unittest.cc

diff --git a/components/translate/core/browser/translate_manager_unittest.cc b/components/translate/core/browser/translate_manager_unittest.cc

index f285e71b0eb84b1448058c888c17b4effebb216c..7c0ba44f42153fd2c68535f0dcdff4062516b4d4 100644

--- a/components/translate/core/browser/translate_manager_unittest.cc

+++ b/components/translate/core/browser/translate_manager_unittest.cc

@@ -4,6 +4,7 @@

#include "components/translate/core/browser/translate_manager.h"

+#include "base/run_loop.h"

#include "base/test/histogram_tester.h"

#include "build/build_config.h"

#include "components/infobars/core/infobar.h"

@@ -47,7 +48,7 @@ class TestNetworkChangeNotifier : public net::NetworkChangeNotifier {

connection_type_to_return_ = type;

net::NetworkChangeNotifier::NotifyObserversOfConnectionTypeChangeForTests(

connection_type_to_return_);

- base::MessageLoop::current()->RunUntilIdle();

+ base::RunLoop().RunUntilIdle();

}

void SimulateOffline() {