Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 2053603002: Roll V8 and its deps and update ICU initialization call (Closed)

Created:
4 years, 6 months ago by jochen (gone - plz use gerrit)
Modified:
4 years, 6 months ago
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Project:
pdfium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : updates #

Patch Set 3 : updates #

Total comments: 1

Patch Set 4 : updates #

Patch Set 5 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -13 lines) Patch
M DEPS View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M build_overrides/v8.gni View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M samples/pdfium_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M testing/embedder_test.cpp View 1 chunk +1 line, -1 line 0 comments Download
M testing/test_support.h View 1 chunk +2 lines, -1 line 0 comments Download
M testing/test_support.cpp View 3 chunks +6 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
jochen (gone - plz use gerrit)
4 years, 6 months ago (2016-06-09 08:36:52 UTC) #1
Michael Achenbach
lgtm - guess you have to roll build too.
4 years, 6 months ago (2016-06-09 08:58:53 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-09 09:30:54 UTC) #3
Michael Achenbach
lgtm https://codereview.chromium.org/2053603002/diff/40001/build_overrides/v8.gni File build_overrides/v8.gni (right): https://codereview.chromium.org/2053603002/diff/40001/build_overrides/v8.gni#newcode9 build_overrides/v8.gni:9: v8_use_external_startup_data = !is_ios v8_use_external_startup_data and v8_optimized_debug shouldn't be ...
4 years, 6 months ago (2016-06-09 09:34:46 UTC) #4
jochen (gone - plz use gerrit)
On 2016/06/09 at 09:34:46, machenbach wrote: > lgtm > > https://codereview.chromium.org/2053603002/diff/40001/build_overrides/v8.gni > File build_overrides/v8.gni (right): ...
4 years, 6 months ago (2016-06-09 09:38:51 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2053603002/80001
4 years, 6 months ago (2016-06-09 09:48:38 UTC) #9
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 09:51:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/9e077d288016ac796fef18c27cd0851c0a07...

Powered by Google App Engine
This is Rietveld 408576698