testing/test_support.h - Issue 2053603002: Roll V8 and its deps and update ICU initialization call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/test_support.h

Issue 2053603002: Roll V8 and its deps and update ICU initialization call (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: updates Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: testing/test_support.h

diff --git a/testing/test_support.h b/testing/test_support.h

index fdb24fe61baf52112ee349461299d2888cb2e070..4111ca61ed625d37a061a698a0e7b2e34474fcff 100644

--- a/testing/test_support.h

+++ b/testing/test_support.h

@@ -83,7 +83,8 @@ bool InitializeV8ForPDFium(const std::string& exe_path,

v8::StartupData* snapshot_blob,

v8::Platform** platform);

#else // V8_USE_EXTERNAL_STARTUP_DATA

-bool InitializeV8ForPDFium(v8::Platform** platform);

+bool InitializeV8ForPDFium(const std::string& exe_path,

+ v8::Platform** platform);

#endif // V8_USE_EXTERNAL_STARTUP_DATA

#endif // PDF_ENABLE_V8

« no previous file with comments | « testing/embedder_test.cpp ('k') | testing/test_support.cpp » ('j') | no next file with comments »