Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Unified Diff: testing/test_support.cpp

Issue 2053603002: Roll V8 and its deps and update ICU initialization call (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: updates Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « testing/test_support.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: testing/test_support.cpp
diff --git a/testing/test_support.cpp b/testing/test_support.cpp
index c50edeba2da888e68b971dbca25cb8a5d2d59a88..96a18a547a10aa0e4dbd47220fe0523624133c72 100644
--- a/testing/test_support.cpp
+++ b/testing/test_support.cpp
@@ -58,8 +58,8 @@ bool GetExternalData(const std::string& exe_path,
}
#endif // V8_USE_EXTERNAL_STARTUP_DATA
-void InitializeV8Common(v8::Platform** platform) {
- v8::V8::InitializeICU();
+void InitializeV8Common(const char* exe_path, v8::Platform** platform) {
+ v8::V8::InitializeICUDefaultLocation(exe_path);
*platform = v8::platform::CreateDefaultPlatform();
v8::V8::InitializePlatform(*platform);
@@ -156,7 +156,7 @@ bool InitializeV8ForPDFium(const std::string& exe_path,
v8::StartupData* natives_blob,
v8::StartupData* snapshot_blob,
v8::Platform** platform) {
- InitializeV8Common(platform);
+ InitializeV8Common(exe_path.c_str(), platform);
if (!GetExternalData(exe_path, bin_dir, "natives_blob.bin", natives_blob))
return false;
if (!GetExternalData(exe_path, bin_dir, "snapshot_blob.bin", snapshot_blob))
@@ -166,8 +166,9 @@ bool InitializeV8ForPDFium(const std::string& exe_path,
return true;
}
#else // V8_USE_EXTERNAL_STARTUP_DATA
-bool InitializeV8ForPDFium(v8::Platform** platform) {
- InitializeV8Common(platform);
+bool InitializeV8ForPDFium(const std::string& exe_path,
+ v8::Platform** platform) {
+ InitializeV8Common(exe_path.c_str(), platform);
return true;
}
#endif // V8_USE_EXTERNAL_STARTUP_DATA
« no previous file with comments | « testing/test_support.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698