samples/pdfium_test.cc - Issue 2053603002: Roll V8 and its deps and update ICU initialization call

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/pdfium_test.cc

Issue 2053603002: Roll V8 and its deps and update ICU initialization call (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: updates Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/pdfium_test.cc

diff --git a/samples/pdfium_test.cc b/samples/pdfium_test.cc

index 9ba11e12e4b506fad5f60747620bb891cf5a2a8b..5ee14642e4b7993f2d5de807f67f7427ca65ddfb 100644

--- a/samples/pdfium_test.cc

+++ b/samples/pdfium_test.cc

@@ -783,7 +783,7 @@ int main(int argc, const char* argv[]) {

InitializeV8ForPDFium(options.exe_path, options.bin_directory, &natives,

&snapshot, &platform);

#else // V8_USE_EXTERNAL_STARTUP_DATA

- InitializeV8ForPDFium(&platform);

+ InitializeV8ForPDFium(options.exe_path, &platform);

#endif // V8_USE_EXTERNAL_STARTUP_DATA

#endif // PDF_ENABLE_V8

« no previous file with comments | « build_overrides/v8.gni ('k') | testing/embedder_test.cpp » ('j') | no next file with comments »