Remove canScroll from WebMouseWheelEvent as it is unused now.

Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
TBR=sky@chromium.org

Committed: https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b
Cr-Commit-Position: refs/heads/master@{#400129}

[dtapuska, 2016-06-09 20:12:56]

Description was changed from

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
==========

to

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
==========

[dtapuska, 2016-06-09 20:12:57]

dtapuska@chromium.org changed reviewers:
+ creis@chromium.org, rbyers@chromium.org, tdresser@chromium.org

[tdresser, 2016-06-10 18:06:46]

LGTM % nits.

https://codereview.chromium.org/2052663004/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl_unittest.cc (right):

https://codereview.chromium.org/2052663004/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl_unittest.cc:2825: // But whenever
the ctrl modifier is applied with canScroll=false, they can
Update comment.

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
File content/common/input/web_input_event_traits.cc (right):

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
content/common/input/web_input_event_traits.cc:524: return
event.hasPreciseScrollingDeltas ||
Don't we also zoom in on touchpad + ctrl?

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
File content/common/input/web_input_event_traits.h (right):

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
content/common/input/web_input_event_traits.h:32: static bool
ShouldCauseScroll(const blink::WebMouseWheelEvent& event);
Perhaps "MayCauseScroll"?

We don't know for sure that something should cause a scroll if this return true,
we just know that it can't cause a scroll if this returns false.

https://codereview.chromium.org/2052663004/diff/20001/content/renderer/input/...
File content/renderer/input/render_widget_input_handler.cc (right):

https://codereview.chromium.org/2052663004/diff/20001/content/renderer/input/...
content/renderer/input/render_widget_input_handler.cc:390: // Send mouse wheel
events and their disposition to the compositor thread, so
Update comment - not longer mouse wheel events.

nit: Let's pluralized disposition, while we're here.

[Charlie Reis, 2016-06-10 18:47:59]

Mostly deferring to tdresser, but content/ LGTM.

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
File content/common/input/web_input_event_traits.h (right):

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
content/common/input/web_input_event_traits.h:32: static bool
ShouldCauseScroll(const blink::WebMouseWheelEvent& event);
On 2016/06/10 18:06:46, tdresser wrote:
> Perhaps "MayCauseScroll"?
> 
> We don't know for sure that something should cause a scroll if this return
true,
> we just know that it can't cause a scroll if this returns false.

+1.  Or CanCauseScroll, to be consistent with CanCoalesce and the old canScroll.

[Rick Byers, 2016-06-10 18:58:52]

Yay, thanks for removing this crap I added :-)

test_runner and WebKit LGTM

[dtapuska, 2016-06-10 19:11:17]

https://codereview.chromium.org/2052663004/diff/20001/content/browser/web_con...
File content/browser/web_contents/web_contents_impl_unittest.cc (right):

https://codereview.chromium.org/2052663004/diff/20001/content/browser/web_con...
content/browser/web_contents/web_contents_impl_unittest.cc:2825: // But whenever
the ctrl modifier is applied with canScroll=false, they can
On 2016/06/10 18:06:46, tdresser wrote:
> Update comment.

Done.

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
File content/common/input/web_input_event_traits.cc (right):

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
content/common/input/web_input_event_traits.cc:524: return
event.hasPreciseScrollingDeltas ||
On 2016/06/10 18:06:46, tdresser wrote:
> Don't we also zoom in on touchpad + ctrl?

We only zoom on low precision touch pads; not high precision touch pads. I know
this is wacky... but it is the way it is.

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
File content/common/input/web_input_event_traits.h (right):

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
content/common/input/web_input_event_traits.h:32: static bool
ShouldCauseScroll(const blink::WebMouseWheelEvent& event);
On 2016/06/10 18:47:58, Charlie Reis wrote:
> On 2016/06/10 18:06:46, tdresser wrote:
> > Perhaps "MayCauseScroll"?
> > 
> > We don't know for sure that something should cause a scroll if this return
> true,
> > we just know that it can't cause a scroll if this returns false.
> 
> +1.  Or CanCauseScroll, to be consistent with CanCoalesce and the old
canScroll.

Done.

https://codereview.chromium.org/2052663004/diff/20001/content/common/input/we...
content/common/input/web_input_event_traits.h:32: static bool
ShouldCauseScroll(const blink::WebMouseWheelEvent& event);
On 2016/06/10 18:06:46, tdresser wrote:
> Perhaps "MayCauseScroll"?
> 
> We don't know for sure that something should cause a scroll if this return
true,
> we just know that it can't cause a scroll if this returns false.

Acknowledged.

https://codereview.chromium.org/2052663004/diff/20001/content/renderer/input/...
File content/renderer/input/render_widget_input_handler.cc (right):

https://codereview.chromium.org/2052663004/diff/20001/content/renderer/input/...
content/renderer/input/render_widget_input_handler.cc:390: // Send mouse wheel
events and their disposition to the compositor thread, so
On 2016/06/10 18:06:46, tdresser wrote:
> Update comment - not longer mouse wheel events.
> 
> nit: Let's pluralized disposition, while we're here.

Done.

[dtapuska, 2016-06-10 20:32:44]

Description was changed from

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
==========

to

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
TBR=sky@chromium.org
==========

[dtapuska, 2016-06-10 20:32:45]

dtapuska@chromium.org changed reviewers:
+ sky@chromium.org

[dtapuska, 2016-06-10 20:47:03]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-06-10 20:47:04]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
tdresser@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2052663004/#ps40001
(title: "Fix nits")

[commit-bot: I haz the power, 2016-06-10 20:47:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052663004/40001

[commit-bot: I haz the power, 2016-06-10 23:05:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 23:05:11]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2016-06-11 00:51:38]

The CQ bit was checked by dtapuska@chromium.org

[commit-bot: I haz the power, 2016-06-11 00:51:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052663004/40001

[commit-bot: I haz the power, 2016-06-11 02:47:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-11 02:47:15]

Try jobs failed on following builders:
  linux_android_rel_ng on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[dtapuska, 2016-06-16 09:34:34]

The CQ bit was checked by dtapuska@chromium.org

[dtapuska, 2016-06-16 09:34:34]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org,
tdresser@chromium.org, rbyers@chromium.org
Link to the patchset: https://codereview.chromium.org/2052663004/#ps80001
(title: "Really fix android unit test")

[commit-bot: I haz the power, 2016-06-16 09:35:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2052663004/80001

[commit-bot: I haz the power, 2016-06-16 11:09:26]

Description was changed from

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
TBR=sky@chromium.org
==========

to

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
TBR=sky@chromium.org
==========

[commit-bot: I haz the power, 2016-06-16 11:09:27]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-06-16 11:09:30]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-16 11:10:38]

Description was changed from

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
TBR=sky@chromium.org
==========

to

==========
Remove canScroll from WebMouseWheelEvent as it is unused now.

Move the common code for querying whether an event causes scrolling
or zooming into web_input_event_traits.h

BUG=598798
TBR=sky@chromium.org

Committed: https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b
Cr-Commit-Position: refs/heads/master@{#400129}
==========

[commit-bot: I haz the power, 2016-06-16 11:10:40]

Patchset 5 (id:??) landed as
https://crrev.com/b8b21416f450a43606e6195b8628b4a903ea439b
Cr-Commit-Position: refs/heads/master@{#400129}