content/browser/renderer_host/input/mouse_wheel_event_queue.cc - Issue 2052663004: Remove canScroll from WebMouseWheelEvent as it is unused now.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/input/mouse_wheel_event_queue.cc

Issue 2052663004: Remove canScroll from WebMouseWheelEvent as it is unused now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Really fix android unit test Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/input/mouse_wheel_event_queue.cc

diff --git a/content/browser/renderer_host/input/mouse_wheel_event_queue.cc b/content/browser/renderer_host/input/mouse_wheel_event_queue.cc

index 89a9f5a4e7f5d6058e2f753a26573d903d3f2222..95f0fc7721aaabc2383436516bfe1f9722bc06d9 100644

--- a/content/browser/renderer_host/input/mouse_wheel_event_queue.cc

+++ b/content/browser/renderer_host/input/mouse_wheel_event_queue.cc

@@ -80,7 +80,7 @@ void MouseWheelEventQueue::ProcessMouseWheelAck(

// If event wasn't consumed then generate a gesture scroll for it.

if (ack_result != INPUT_EVENT_ACK_STATE_CONSUMED &&

- event_sent_for_gesture_ack_->event.canScroll &&

+ WebInputEventTraits::CanCauseScroll(event_sent_for_gesture_ack_->event) &&

event_sent_for_gesture_ack_->event.resendingPluginId == -1 &&

(scrolling_device_ == blink::WebGestureDeviceUninitialized ||

scrolling_device_ == blink::WebGestureDeviceTouchpad)) {

« no previous file with comments | « components/test_runner/event_sender.cc ('k') | content/browser/renderer_host/render_widget_host_view_aura_unittest.cc » ('j') | no next file with comments »