Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Side by Side Diff: content/common/input/web_input_event_traits.cc

Issue 2052663004: Remove canScroll from WebMouseWheelEvent as it is unused now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Really fix android unit test Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/common/input/web_input_event_traits.h" 5 #include "content/common/input/web_input_event_traits.h"
6 6
7 #include <bitset> 7 #include <bitset>
8 #include <limits> 8 #include <limits>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 event.windowX, 48 event.windowX,
49 event.windowY, 49 event.windowY,
50 event.globalX, 50 event.globalX,
51 event.globalY, 51 event.globalY,
52 event.movementX, 52 event.movementX,
53 event.movementY, 53 event.movementY,
54 event.clickCount); 54 event.clickCount);
55 } 55 }
56 56
57 void ApppendEventDetails(const WebMouseWheelEvent& event, std::string* result) { 57 void ApppendEventDetails(const WebMouseWheelEvent& event, std::string* result) {
58 StringAppendF(result, 58 StringAppendF(
59 "{\n Delta: (%f, %f)\n WheelTicks: (%f, %f)\n Accel: (%f, %f)\n" 59 result,
60 " ScrollByPage: %d\n HasPreciseScrollingDeltas: %d\n" 60 "{\n Delta: (%f, %f)\n WheelTicks: (%f, %f)\n Accel: (%f, %f)\n"
61 " Phase: (%d, %d)\n CanRubberband: (%d, %d)\n CanScroll: %d\n}", 61 " ScrollByPage: %d\n HasPreciseScrollingDeltas: %d\n"
62 event.deltaX, 62 " Phase: (%d, %d)\n CanRubberband: (%d, %d)\n}",
63 event.deltaY, 63 event.deltaX, event.deltaY, event.wheelTicksX, event.wheelTicksY,
64 event.wheelTicksX, 64 event.accelerationRatioX, event.accelerationRatioY, event.scrollByPage,
65 event.wheelTicksY, 65 event.hasPreciseScrollingDeltas, event.phase, event.momentumPhase,
66 event.accelerationRatioX, 66 event.canRubberbandLeft, event.canRubberbandRight);
67 event.accelerationRatioY,
68 event.scrollByPage,
69 event.hasPreciseScrollingDeltas,
70 event.phase,
71 event.momentumPhase,
72 event.canRubberbandLeft,
73 event.canRubberbandRight,
74 event.canScroll);
75 } 67 }
76 68
77 void ApppendEventDetails(const WebGestureEvent& event, std::string* result) { 69 void ApppendEventDetails(const WebGestureEvent& event, std::string* result) {
78 StringAppendF(result, 70 StringAppendF(result,
79 "{\n Pos: (%d, %d)\n GlobalPos: (%d, %d)\n SourceDevice: %d\n" 71 "{\n Pos: (%d, %d)\n GlobalPos: (%d, %d)\n SourceDevice: %d\n"
80 " RawData: (%f, %f, %f, %f, %d)\n}", 72 " RawData: (%f, %f, %f, %f, %d)\n}",
81 event.x, 73 event.x,
82 event.y, 74 event.y,
83 event.globalX, 75 event.globalX,
84 event.globalY, 76 event.globalY,
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
146 event->movementY += y; 138 event->movementY += y;
147 } 139 }
148 140
149 bool CanCoalesce(const WebMouseWheelEvent& event_to_coalesce, 141 bool CanCoalesce(const WebMouseWheelEvent& event_to_coalesce,
150 const WebMouseWheelEvent& event) { 142 const WebMouseWheelEvent& event) {
151 return event.modifiers == event_to_coalesce.modifiers && 143 return event.modifiers == event_to_coalesce.modifiers &&
152 event.scrollByPage == event_to_coalesce.scrollByPage && 144 event.scrollByPage == event_to_coalesce.scrollByPage &&
153 event.phase == event_to_coalesce.phase && 145 event.phase == event_to_coalesce.phase &&
154 event.momentumPhase == event_to_coalesce.momentumPhase && 146 event.momentumPhase == event_to_coalesce.momentumPhase &&
155 event.hasPreciseScrollingDeltas == 147 event.hasPreciseScrollingDeltas ==
156 event_to_coalesce.hasPreciseScrollingDeltas && 148 event_to_coalesce.hasPreciseScrollingDeltas;
157 event.canScroll == event_to_coalesce.canScroll;
158 } 149 }
159 150
160 float GetUnacceleratedDelta(float accelerated_delta, float acceleration_ratio) { 151 float GetUnacceleratedDelta(float accelerated_delta, float acceleration_ratio) {
161 return accelerated_delta * acceleration_ratio; 152 return accelerated_delta * acceleration_ratio;
162 } 153 }
163 154
164 float GetAccelerationRatio(float accelerated_delta, float unaccelerated_delta) { 155 float GetAccelerationRatio(float accelerated_delta, float unaccelerated_delta) {
165 if (unaccelerated_delta == 0.f || accelerated_delta == 0.f) 156 if (unaccelerated_delta == 0.f || accelerated_delta == 0.f)
166 return 1.f; 157 return 1.f;
167 return unaccelerated_delta / accelerated_delta; 158 return unaccelerated_delta / accelerated_delta;
(...skipping 350 matching lines...) Expand 10 before | Expand all | Expand 10 after
518 WebInputEvent::Blocking; 509 WebInputEvent::Blocking;
519 510
520 // Touch move events may be non-blocking but are always explicitly 511 // Touch move events may be non-blocking but are always explicitly
521 // acknowledge by the renderer so they block the event stream. 512 // acknowledge by the renderer so they block the event stream.
522 case WebInputEvent::TouchMove: 513 case WebInputEvent::TouchMove:
523 default: 514 default:
524 return true; 515 return true;
525 } 516 }
526 } 517 }
527 518
519 bool WebInputEventTraits::CanCauseScroll(
520 const blink::WebMouseWheelEvent& event) {
521 #if defined(USE_AURA)
522 // Scroll events generated from the mouse wheel when the control key is held
523 // don't trigger scrolling. Instead, they may cause zooming.
524 return event.hasPreciseScrollingDeltas ||
525 (event.modifiers & blink::WebInputEvent::ControlKey) == 0;
526 #else
527 return true;
528 #endif
529 }
530
528 uint32_t WebInputEventTraits::GetUniqueTouchEventId( 531 uint32_t WebInputEventTraits::GetUniqueTouchEventId(
529 const WebInputEvent& event) { 532 const WebInputEvent& event) {
530 if (WebInputEvent::isTouchEventType(event.type)) { 533 if (WebInputEvent::isTouchEventType(event.type)) {
531 return static_cast<const WebTouchEvent&>(event).uniqueTouchEventId; 534 return static_cast<const WebTouchEvent&>(event).uniqueTouchEventId;
532 } 535 }
533 return 0U; 536 return 0U;
534 } 537 }
535 538
536 } // namespace content 539 } // namespace content
OLDNEW
« no previous file with comments | « content/common/input/web_input_event_traits.h ('k') | content/common/input/web_input_event_traits_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698